From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Check for I915_MODE_FLAG_INHERITED before drm_atomic_helper_check_modeset Date: Fri, 02 Mar 2018 11:37:17 +0200 Message-ID: <87o9k6u8c2.fsf@intel.com> References: <20180221092808.30060-1-maarten.lankhorst@linux.intel.com> <1519956180.9205.11.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A1E86EF08 for ; Fri, 2 Mar 2018 09:36:22 +0000 (UTC) In-Reply-To: <1519956180.9205.11.camel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lyude Paul , Maarten Lankhorst , intel-gfx@lists.freedesktop.org Cc: "Sarvela, Tomi P" , Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAwMSBNYXIgMjAxOCwgTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4gd3JvdGU6 Cj4gUHVzaGVkIHdpdGggc29tZSBzbWFsbCB3aGl0ZXNwYWNlIGNoYW5nZXMgdG8gbWFrZSBzcGFy c2UgaGFwcHksIHRoYW5rcyEKClBsZWFzZSBkbyBub3QgcHVzaCBwYXRjaGVzIGJlZm9yZSB0aGV5 J3ZlIHBhc3NlZCBDSS4gVGhpcyBwYXRjaCBnaXZlcyBbMV06CgpbICAyODEuMTY3MDMzXSBpOTE1 IDAwMDA6MDA6MDIuMDogRFAtMjogRURJRCBpcyBpbnZhbGlkOgouLi4KWyAgMjgyLjgwNjM5M10g W2RybTppbnRlbF9lbmFibGVfc2hhcmVkX2RwbGwgW2k5MTVdXSAqRVJST1IqIERQTEwgMSBub3Qg bG9ja2VkCgpJIGRvbid0IGtub3cgaWYgdGhpcyBpcyBjYXVzZWQgYnkgdGhlIHBhdGNoLCBidXQg c2luY2Ugd2UgZ2V0IHRoaXMgaW4KdGhlIEJBVCByb3VuZCwgdGhlIGZ1bGwgSUdUIHRlc3Rpbmcg d2Fzbid0IGV2ZW4gcnVuIGhlcmUuCgoKQlIsCkphbmkuCgoKWzFdIGh0dHBzOi8vaW50ZWwtZ2Z4 LWNpLjAxLm9yZy90cmVlL2RybS10aXAvUGF0Y2h3b3JrXzgxMDIvZmktc2tsLTY3MDBrMi9pZ3RA a21zX2NoYW1lbGl1bUBjb21tb24taHBkLWFmdGVyLXN1c3BlbmQuaHRtbAo+Cj4gT24gV2VkLCAy MDE4LTAyLTIxIGF0IDEwOjI4ICswMTAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToKPj4gTW92 aW5nIHRoZSBjaGVjayB1cHdhcmRzIHdpbGwgbWVhbiB3ZSB3ZSBubyBsb25nZXIgaGF2ZSB0byBh ZGQgcGxhbmVzCj4+IGFuZCBjb25uZWN0b3JzIG1hbnVhbGx5LCBiZWNhdXNlIGV2ZXJ5dGhpbmcg aXMgaGFuZGxlZCBjb3JyZWN0bHkgYnkKPj4gZHJtX2F0b21pY19oZWxwZXJfY2hlY2tfbW9kZXNl dCgpIGFzIGludGVuZGVkLgo+PiAKPj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3Qg PG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPj4gQ2M6IEx5dWRlIFBhdWwgPGx5 dWRlQHJlZGhhdC5jb20+Cj4+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xs LmNoPgo+PiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5j aD4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAyMCAr KysrKy0tLS0tLS0tLS0tLS0tLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwg MTUgZGVsZXRpb25zKC0pCj4+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jCj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j Cj4+IGluZGV4IDY1YmU3YWY3ZjY0Ny4uYzVjYzkwMjJkNTQ1IDEwMDY0NAo+PiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+IEBAIC0xMTkyNyw2ICsxMTkyNywxMSBAQCBzdGF0aWMg aW50IGludGVsX2F0b21pY19jaGVjayhzdHJ1Y3QgZHJtX2RldmljZQo+PiAqZGV2LAo+PiAgCWlu dCByZXQsIGk7Cj4+ICAJYm9vbCBhbnlfbXMgPSBmYWxzZTsKPj4gIAo+PiArCS8qIENhdGNoIEk5 MTVfTU9ERV9GTEFHX0lOSEVSSVRFRCAqLwo+PiArCWZvcl9lYWNoX29sZG5ld19jcnRjX2luX3N0 YXRlKHN0YXRlLCBjcnRjLCBvbGRfY3J0Y19zdGF0ZSwKPj4gY3J0Y19zdGF0ZSwgaSkKPj4gKwkJ aWYgKGNydGNfc3RhdGUtPm1vZGUucHJpdmF0ZV9mbGFncyAhPSBvbGRfY3J0Y19zdGF0ZS0KPj4g Pm1vZGUucHJpdmF0ZV9mbGFncykKPj4gKwkJCWNydGNfc3RhdGUtPm1vZGVfY2hhbmdlZCA9IHRy dWU7Cj4+ICsKPj4gIAlyZXQgPSBkcm1fYXRvbWljX2hlbHBlcl9jaGVja19tb2Rlc2V0KGRldiwg c3RhdGUpOwo+PiAgCWlmIChyZXQpCj4+ICAJCXJldHVybiByZXQ7Cj4+IEBAIC0xMTkzNSwxMCAr MTE5NDAsNiBAQCBzdGF0aWMgaW50IGludGVsX2F0b21pY19jaGVjayhzdHJ1Y3QgZHJtX2Rldmlj ZQo+PiAqZGV2LAo+PiAgCQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcgPQo+ PiAgCQkJdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjX3N0YXRlKTsKPj4gIAo+PiAtCQkvKiBDYXRj aCBJOTE1X01PREVfRkxBR19JTkhFUklURUQgKi8KPj4gLQkJaWYgKGNydGNfc3RhdGUtPm1vZGUu cHJpdmF0ZV9mbGFncyAhPSBvbGRfY3J0Y19zdGF0ZS0KPj4gPm1vZGUucHJpdmF0ZV9mbGFncykK Pj4gLQkJCWNydGNfc3RhdGUtPm1vZGVfY2hhbmdlZCA9IHRydWU7Cj4+IC0KPj4gIAkJaWYgKCFu ZWVkc19tb2Rlc2V0KGNydGNfc3RhdGUpKQo+PiAgCQkJY29udGludWU7Cj4+ICAKPj4gQEAgLTEx OTQ3LDEzICsxMTk0OCw2IEBAIHN0YXRpYyBpbnQgaW50ZWxfYXRvbWljX2NoZWNrKHN0cnVjdCBk cm1fZGV2aWNlCj4+ICpkZXYsCj4+ICAJCQljb250aW51ZTsKPj4gIAkJfQo+PiAgCj4+IC0JCS8q IEZJWE1FOiBGb3Igb25seSBhY3RpdmVfY2hhbmdlZCB3ZSBzaG91bGRuJ3QgbmVlZCB0byBkbwo+ PiBhbnkKPj4gLQkJICogc3RhdGUgcmVjb21wdXRhdGlvbiBhdCBhbGwuICovCj4+IC0KPj4gLQkJ cmV0ID0gZHJtX2F0b21pY19hZGRfYWZmZWN0ZWRfY29ubmVjdG9ycyhzdGF0ZSwgY3J0Yyk7Cj4+ IC0JCWlmIChyZXQpCj4+IC0JCQlyZXR1cm4gcmV0Owo+PiAtCj4+ICAJCXJldCA9IGludGVsX21v ZGVzZXRfcGlwZV9jb25maWcoY3J0YywgcGlwZV9jb25maWcpOwo+PiAgCQlpZiAocmV0KSB7Cj4+ ICAJCQlpbnRlbF9kdW1wX3BpcGVfY29uZmlnKHRvX2ludGVsX2NydGMoY3J0YyksCj4+IEBAIC0x MTk3MiwxMCArMTE5NjYsNiBAQCBzdGF0aWMgaW50IGludGVsX2F0b21pY19jaGVjayhzdHJ1Y3Qg ZHJtX2RldmljZQo+PiAqZGV2LAo+PiAgCQlpZiAobmVlZHNfbW9kZXNldChjcnRjX3N0YXRlKSkK Pj4gIAkJCWFueV9tcyA9IHRydWU7Cj4+ICAKPj4gLQkJcmV0ID0gZHJtX2F0b21pY19hZGRfYWZm ZWN0ZWRfcGxhbmVzKHN0YXRlLCBjcnRjKTsKPj4gLQkJaWYgKHJldCkKPj4gLQkJCXJldHVybiBy ZXQ7Cj4+IC0KPj4gIAkJaW50ZWxfZHVtcF9waXBlX2NvbmZpZyh0b19pbnRlbF9jcnRjKGNydGMp LCBwaXBlX2NvbmZpZywKPj4gIAkJCQkgICAgICAgbmVlZHNfbW9kZXNldChjcnRjX3N0YXRlKSA/ Cj4+ICAJCQkJICAgICAgICJbbW9kZXNldF0iIDogIltmYXN0c2V0XSIpOwoKLS0gCkphbmkgTmlr dWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK