All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stewart Smith <stewart@linux.vnet.ibm.com>
To: Patrick Venture <venture@google.com>,
	Alexander Amelkin <a.amelkin@yadro.com>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: Proprietary task references in commit logs
Date: Wed, 14 Feb 2018 14:30:47 +1100	[thread overview]
Message-ID: <87o9ksfdso.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAO=notw8DrRUP7MiFmDcQ9jqypeFqs6xmwXxPYt_jPf+dtP0DQ@mail.gmail.com>

Patrick Venture <venture@google.com> writes:
> Alexander;
>
> So, we've been in a similar boat, in that we have a Google-Bug-Id in
> all our commits.  However, for openbmc we've been trimming them out.
> I think part of the argument is to keep the commit message clean, or
> if necessary file a corresponding bug in the openbmc bug track, and
> then close that bug id.

I've been poked at this for other firmware too, and I tend to dislike
non-public bug tracker IDs in public repositories.

I have an idea of using git-notes to have a local tree of `fixes` (even
added retroactively) that could then be queried/modified that would suit
this kind of use case.

Of course, finding enough time to write the couple of hundred lines of
python to do that has been elusive :)

-- 
Stewart Smith
OPAL Architect, IBM.

  reply	other threads:[~2018-02-14  3:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13 13:13 Proprietary task references in commit logs Alexander Amelkin
2018-02-13 16:27 ` Patrick Venture
2018-02-14  3:30   ` Stewart Smith [this message]
2018-02-14  8:07     ` Alexander Amelkin
2018-02-16  1:03       ` Andrew Jeffery
2018-02-21 12:38         ` Patrick Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9ksfdso.fsf@linux.vnet.ibm.com \
    --to=stewart@linux.vnet.ibm.com \
    --cc=a.amelkin@yadro.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=venture@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.