From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 17/22] drm/vc4: Use drm_fb_cma_fbdev_init/fini() Date: Mon, 06 Nov 2017 08:19:21 -0800 Message-ID: <87o9ofs7li.fsf@anholt.net> References: <20171104130416.12423-1-noralf@tronnes.org> <20171104130416.12423-18-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0419391813==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id BE8E46E391 for ; Mon, 6 Nov 2017 16:19:24 +0000 (UTC) In-Reply-To: <20171104130416.12423-18-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= , dri-devel@lists.freedesktop.org Cc: narmstrong@baylibre.com, liviu.dudau@arm.com, laurent.pinchart@ideasonboard.com, marex@denx.de, boris.brezillon@free-electrons.com, abrodkin@synopsys.com, z.liuxinliang@hisilicon.com, kong.kongxinwei@hisilicon.com, tomi.valkeinen@ti.com, david@lechnology.com, puck.chen@hisilicon.com, jsarha@ti.com, vincent.abriou@st.com, alison.wang@freescale.com, philippe.cornu@st.com, yannick.fertre@st.com, zourongrong@gmail.com, maxime.ripard@free-electrons.com, shawnguo@kernel.org List-Id: dri-devel@lists.freedesktop.org --===============0419391813== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Noralf Tr=C3=B8nnes writes: > Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on > the fact that drm_device holds a pointer to the drm_fb_helper structure. > This means that the driver doesn't have to keep track of that. > Also use the drm_fb_helper functions directly. Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAloAi4kACgkQtdYpNtH8 nuj7YhAAn/3Wup3WU7qFA7dcN1ST0qLJdXf8fzEm2LDRWGtYpAwPszyWrpUZ6Hwv 0vdiil3DxcAn3uBcJ1LiTiQa++4faldSmUFAISnAsaViHGObQfZDybB7SDndexMX Tl/oW84c8snRepPwH0v0L9VXOvjzmMcLxmGPdZR90fdkOov/h39hl6mLsIPe21HG W24rASnKCcDx9m0rCvJxcLReGsMRAngia57T7/tcPS7zcA9X4KZDOe00qqjcGLWy 2Jvo49hTxOSkyu/RJPmVyHnVcJAAmtbVhk3SUisDAo2lMk4393k2p2plxUIXPOHU Nbwf5CHyJb04466BuKUK9DmIwCVcf3p7DUVJWZc6wzmepLiY9Nk2Fs5IfZCzLHYP /r/9XiZFui1iWpruXnTRw6FlKQBhBgGqtQuQ6x0vAW6glpX0UH6GNRtufqavY+1A MwpYFRkgyWUDqd9HDrwba+O+XLiR+hoR6z74JkXHRwlwUaVMyPXYtYMLag44MbSu SidP5/cVfjCIqtJApUvwMIUvbKMY+n1ctE8l6NetpUxWMsD1AGClQsZVgYUdnlJr LG8r68LLpHWor2NcdmuESIC8hhL5nw+QQVbx/V5W+jdWVO15hgCpGlZITw8/uolB 6L2UqbO0mqOWLV4L2J5J8oJY914noaQ2U6bl2KRmrg5hwKSLhqk= =155f -----END PGP SIGNATURE----- --=-=-=-- --===============0419391813== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0419391813==--