From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dprVK-0007kD-TU for qemu-devel@nongnu.org; Thu, 07 Sep 2017 03:45:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dprVH-0007VW-Pq for qemu-devel@nongnu.org; Thu, 07 Sep 2017 03:45:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45796) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dprVH-0007VB-Jb for qemu-devel@nongnu.org; Thu, 07 Sep 2017 03:45:35 -0400 From: Markus Armbruster References: <150471856141.24907.274176769201097378.stgit@frigg.lan> Date: Thu, 07 Sep 2017 09:45:29 +0200 In-Reply-To: <150471856141.24907.274176769201097378.stgit@frigg.lan> (=?utf-8?Q?=22Llu=C3=ADs?= Vilanova"'s message of "Wed, 6 Sep 2017 20:22:41 +0300") Message-ID: <87o9qnkl46.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 00/20] instrument: Add basic event instrumentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Llu=C3=ADs?= Vilanova Cc: qemu-devel@nongnu.org, "Emilio G. Cota" , Stefan Hajnoczi Llu=C3=ADs Vilanova writes: > This series adds an API to add instrumentation events. > > It also provides additional APIs for: > * Controlling tracing events > * Peek/poke guest memory > > There's still missing APIs for (can be added in later series?): > * Provide something like tracing's per-vCPU trace states (i.e., so that e= ach > vCPU can have different instrumentation code). It's still not clear to = me if > we should extend the per-vCPU bitmap with instrumentation events, or ot= herwise > somehow reuse the bits in tracing events (since they're currently limit= ed). > * Peek/poke guest registers > > The instrumentation code is dynamically loaded as a library into QEMU eit= her > when it starts or later using its remote control interfaces. > > Signed-off-by: Llu=C3=ADs Vilanova Doesn't apply to current master, and appears to have whitespace errors. Please rebase and use scripts/checkpatch.pl to tidy up.