Re: [Qemu-devel] [PATCH v2] tests: Enable the drive_del test also on s390x

[Markus Armbruster <armbru@redhat.com>]

David Hildenbrand <david@redhat.com> writes:

>>  static void test_drive_del_device_del(void)
>>  {
>> +    char *args;
>> +
>>      /* Start with a drive used by a device that unplugs instantaneously */
>> -    qtest_start("-drive if=none,id=drive0,file=null-co://,format=raw"
>> -                " -device virtio-scsi-pci"
>> -                " -device scsi-hd,drive=drive0,id=dev0");
>> +    args = g_strdup_printf("-drive if=none,id=drive0,file=null-co://,format=raw"
>> +                           " -device virtio-scsi-%s"
>> +                           " -device scsi-hd,drive=drive0,id=dev0",
>
> Would look better with the spaces at the end of the previous line (so
> all "-device" are aligned), but just my taste.

The -device *are* aligned, but I get what you mean.

The advantage of leading rather than trailing space is that the
intention "this is still the same string" is locally obvious both at the
first part's end (no comma) and at the second part's beginning (leading
space).

>> +                           qvirtio_get_dev_type());
>> +    qtest_start(args);
>>  
>>      /*
>>       * Delete the drive, and then the device
[...]