From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915/opregion: Remove null check before kfree Date: Thu, 31 Aug 2017 09:30:05 +0300 Message-ID: <87o9qw8d1u.fsf@intel.com> References: <1504099876-4142-1-git-send-email-himanshujha199640@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1504099876-4142-1-git-send-email-himanshujha199640@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Cc: intel-gfx@lists.freedesktop.org, joonas.lahtinen@linux.intel.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Himanshu Jha , rodrigo.vivi@intel.com List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAzMCBBdWcgMjAxNywgSGltYW5zaHUgSmhhIDxoaW1hbnNodWpoYTE5OTY0MEBnbWFp bC5jb20+IHdyb3RlOgo+IGtmcmVlIG9uIE5VTEwgcG9pbnRlciBpcyBhIG5vLW9wIGFuZCB0aGVy ZWZvcmUgY2hlY2tpbmcgaXMgcmVkdW5kYW50LgoKSU1PIHRoZSBjb2RlIGhhcyBtb3JlIGNsYXJp dHkgYXMgaXQgaXMuCgpCUiwKSmFuaS4KCj4KPiBTaWduZWQtb2ZmLWJ5OiBIaW1hbnNodSBKaGEg PGhpbWFuc2h1amhhMTk5NjQwQGdtYWlsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfb3ByZWdpb24uYyB8IDYgKystLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2Vy dGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfb3ByZWdpb24uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX29wcmVn aW9uLmMKPiBpbmRleCA5ODE1NGVmLi4yNDI3YjQwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX29wcmVnaW9uLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9vcHJlZ2lvbi5jCj4gQEAgLTgzMCwxMCArODMwLDggQEAgdm9pZCBpbnRlbF9vcHJlZ2lv bl91bnJlZ2lzdGVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQltZW11 bm1hcChvcHJlZ2lvbi0+cnZkYSk7Cj4gIAkJb3ByZWdpb24tPnJ2ZGEgPSBOVUxMOwo+ICAJfQo+ IC0JaWYgKG9wcmVnaW9uLT52YnRfZmlybXdhcmUpIHsKPiAtCQlrZnJlZShvcHJlZ2lvbi0+dmJ0 X2Zpcm13YXJlKTsKPiAtCQlvcHJlZ2lvbi0+dmJ0X2Zpcm13YXJlID0gTlVMTDsKPiAtCX0KPiAr CWtmcmVlKG9wcmVnaW9uLT52YnRfZmlybXdhcmUpOwo+ICsJb3ByZWdpb24tPnZidF9maXJtd2Fy ZSA9IE5VTEw7Cj4gIAlvcHJlZ2lvbi0+aGVhZGVyID0gTlVMTDsKPiAgCW9wcmVnaW9uLT5hY3Bp ID0gTlVMTDsKPiAgCW9wcmVnaW9uLT5zd3NjaSA9IE5VTEw7CgotLSAKSmFuaSBOaWt1bGEsIElu dGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750872AbdHaGaU (ORCPT ); Thu, 31 Aug 2017 02:30:20 -0400 Received: from mga14.intel.com ([192.55.52.115]:53381 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711AbdHaGaS (ORCPT ); Thu, 31 Aug 2017 02:30:18 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,451,1498546800"; d="scan'208";a="895780866" From: Jani Nikula To: Himanshu Jha Cc: joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Himanshu Jha Subject: Re: [PATCH] drm/i915/opregion: Remove null check before kfree In-Reply-To: <1504099876-4142-1-git-send-email-himanshujha199640@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1504099876-4142-1-git-send-email-himanshujha199640@gmail.com> Date: Thu, 31 Aug 2017 09:30:05 +0300 Message-ID: <87o9qw8d1u.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Aug 2017, Himanshu Jha wrote: > kfree on NULL pointer is a no-op and therefore checking is redundant. IMO the code has more clarity as it is. BR, Jani. > > Signed-off-by: Himanshu Jha > --- > drivers/gpu/drm/i915/intel_opregion.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c > index 98154ef..2427b40 100644 > --- a/drivers/gpu/drm/i915/intel_opregion.c > +++ b/drivers/gpu/drm/i915/intel_opregion.c > @@ -830,10 +830,8 @@ void intel_opregion_unregister(struct drm_i915_private *dev_priv) > memunmap(opregion->rvda); > opregion->rvda = NULL; > } > - if (opregion->vbt_firmware) { > - kfree(opregion->vbt_firmware); > - opregion->vbt_firmware = NULL; > - } > + kfree(opregion->vbt_firmware); > + opregion->vbt_firmware = NULL; > opregion->header = NULL; > opregion->acpi = NULL; > opregion->swsci = NULL; -- Jani Nikula, Intel Open Source Technology Center