From: Juan Quintela <quintela@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, kwolf@redhat.com,
famz@redhat.com, jsnow@redhat.com, qemu-stable@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 02/12] migration: Don't lose errno across aio context changes
Date: Tue, 18 Apr 2017 22:02:50 +0200 [thread overview]
Message-ID: <87o9vth4b9.fsf@secure.mitica> (raw)
In-Reply-To: <20170412174920.8744-3-eblake@redhat.com> (Eric Blake's message of "Wed, 12 Apr 2017 12:49:10 -0500")
Eric Blake <eblake@redhat.com> wrote:
> set_drity_tracking() was assuming that the errno value set by
> bdrv_create_dirty_bitmap() would not be corrupted by either
> blk_get_aio_context() or aio_context_release(). Rather than
> audit whether this assumption is safe, rewrite the code to just
> grab the value of errno sooner.
>
> CC: qemu-stable@nongnu.org
> Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2017-04-18 20:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 17:49 [Qemu-devel] [PATCH 00/12] make dirty-bitmap byte-based Eric Blake
2017-04-12 17:49 ` [Qemu-devel] [PATCH 01/12] dirty-bitmap: Report BlockDirtyInfo.count in bytes, as documented Eric Blake
2017-04-12 22:43 ` John Snow
2017-04-12 17:49 ` [Qemu-devel] [PATCH 02/12] migration: Don't lose errno across aio context changes Eric Blake
2017-04-12 22:44 ` John Snow
2017-04-18 20:02 ` Juan Quintela [this message]
2017-04-12 17:49 ` [Qemu-devel] [PATCH 03/12] dirty-bitmap: Drop unused functions Eric Blake
2017-04-12 22:47 ` John Snow
2017-04-12 23:36 ` Eric Blake
2017-04-12 23:40 ` John Snow
2017-04-13 9:19 ` Vladimir Sementsov-Ogievskiy
2017-04-13 16:57 ` John Snow
2017-04-12 17:49 ` [Qemu-devel] [PATCH 04/12] dirty-bitmap: Track size in bytes Eric Blake
2017-04-12 23:32 ` John Snow
2017-04-12 17:49 ` [Qemu-devel] [PATCH 05/12] dirty-bitmap: Set iterator start by offset, not sector Eric Blake
2017-04-13 0:00 ` John Snow
2017-04-12 17:49 ` [Qemu-devel] [PATCH 06/12] dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset Eric Blake
2017-04-13 0:10 ` John Snow
2017-04-12 17:49 ` [Qemu-devel] [PATCH 07/12] dirty-bitmap: Change bdrv_get_dirty_count() to report bytes Eric Blake
2017-04-13 0:19 ` John Snow
2017-04-13 0:22 ` John Snow
2017-04-12 17:49 ` [Qemu-devel] [PATCH 08/12] dirty-bitmap: Change bdrv_get_dirty() to take bytes Eric Blake
2017-04-13 0:25 ` John Snow
2017-04-13 0:48 ` Eric Blake
2017-04-12 17:49 ` [Qemu-devel] [PATCH 09/12] dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytes Eric Blake
2017-04-13 0:29 ` John Snow
2017-04-12 17:49 ` [Qemu-devel] [PATCH 10/12] mirror: Switch mirror_dirty_init() to byte-based iteration Eric Blake
2017-04-13 1:24 ` John Snow
2017-04-12 17:49 ` [Qemu-devel] [PATCH 11/12] dirty-bitmap: Switch bdrv_set_dirty() to bytes Eric Blake
2017-04-13 1:28 ` John Snow
2017-04-12 17:49 ` [Qemu-devel] [PATCH 12/12] dirty-bitmap: Convert internal hbitmap size/granularity Eric Blake
2017-04-13 1:38 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9vth4b9.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.