From: Jani Nikula <jani.nikula@linux.intel.com>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: kbl_guc and bxt_guc firmware missing from linux-firmware
Date: Wed, 15 Mar 2017 12:54:38 +0200 [thread overview]
Message-ID: <87o9x27qtt.fsf@intel.com> (raw)
In-Reply-To: <20170301142033.GI122517@ubuntu-hedt>
On Wed, 01 Mar 2017, Seth Forshee <seth.forshee@canonical.com> wrote:
> On Wed, Mar 01, 2017 at 03:23:06PM +0200, Jani Nikula wrote:
>> On Wed, 15 Feb 2017, Seth Forshee <seth.forshee@canonical.com> wrote:
>> > Maybe it would be good to have something like MODULE_OPTIONAL_FIRMWARE
>> > to identify firmware that isn't required but will be used by the driver
>> > if available. Then mkinitramfs can try to copy those files along with
>> > the module but know that there's no need to produce a warning if it's
>> > not present.
>>
>> The documentation for the current MODULE_FIRMWARE already says,
>> "Optional firmware file (or files) needed by the module format is simply
>> firmware file name."
>
> That may have been the intention. But since it is the only thing
> available it has been used for any firmware files, including many which
> will cause device probe to fail if not present. Userspace tools seem to
> treat the firmware files in modinfo to mean, "firmware files without
> which the hardware may fail to function or may not function properly,"
> because in many cases that is true. I'd argue that this is the de facto
> definition of MODULE_FIRMWARE, and that the comment is at best
> misleading.
Just a quick follow-up. We may choose to improve the MODULE_FIRMWARE
mechanism in the long run, but for the time being we're committed to
only adding the MODULE_FIRMWARE statements once the blobs have hit the
linux-firmware repository. For example, we'll queue a fix to v4.11-rc3
(or -rc4 at the latest) removing one such statement.
Thanks again for your feedback.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-03-15 10:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 13:39 kbl_guc and bxt_guc firmware missing from linux-firmware Seth Forshee
2017-02-15 10:28 ` Jani Nikula
2017-02-15 13:01 ` Seth Forshee
2017-02-15 22:56 ` Vivi, Rodrigo
2017-03-01 13:23 ` Jani Nikula
2017-03-01 14:20 ` Seth Forshee
2017-03-15 10:54 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9x27qtt.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.