From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH] drm/i915: Avoid tweaking evaluation thresholds on Baytrail v3 Date: Mon, 27 Feb 2017 15:22:28 +0200 Message-ID: <87o9xnbwff.fsf@gaia.fi.intel.com> References: <1487162270-14556-1-git-send-email-mika.kuoppala@intel.com> <1487166779-26945-1-git-send-email-mika.kuoppala@intel.com> <20170227092519.GE13095@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 299FA6E427 for ; Mon, 27 Feb 2017 13:23:50 +0000 (UTC) In-Reply-To: <20170227092519.GE13095@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Len Brown , Michal Feix , Jani Nikula , Daniel Vetter , intel-gfx@lists.freedesktop.org, fritsch@xbmc.org, Hans de Goede , miku@iki.fi, Jarkko Nikula , Ezequiel Garcia , "# v4 . 2+" List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gT24gV2Vk LCBGZWIgMTUsIDIwMTcgYXQgMDM6NTI6NTlQTSArMDIwMCwgTWlrYSBLdW9wcGFsYSB3cm90ZToK Pj4gQ2VydGFpbiBCYXl0cmFpbHMsIG5hbWVseSB0aGUgNCBjcHUgY29yZSB2YXJpYW50cywgaGF2 ZSBiZWVuCj4+IHBsYXF1ZWQgYnkgc3B1cmlvdXMgc3lzdGVtIGhhbmdzLCBtb3N0bHkgb2NjdXJy aW5nIHdpdGggbGlnaHQgbG9hZHMuCj4+IAo+PiBNdWx0aXBsZSBiaXNlY3RzIGJ5IHZhcmlvdXMg cGVvcGxlIHBvaW50IHRvIGEgY29tbWl0IHdoaWNoIGNoYW5nZXMgdGhlCj4+IHJlY2xvY2tpbmcg c3RyYXRlZ3kgZm9yIEJheXRyYWlsIHRvIGZvbGxvdyBpdHMgYmlnZ2VyIGJyZXRoZW46Cj4+IGNv bW1pdCA4ZmI1NTE5N2U2NGQgKCJkcm0vaTkxNTogQWdyZXNzaXZlIGRvd25jbG9ja2luZyBvbiBC YXl0cmFpbCIpCj4+IAo+PiBUaGVyZSBpcyBhbHNvIGEgcmV2aWV3IGNvbW1lbnQgYXR0YWNoZWQg dG8gdGhpcyBjb21taXQgZnJvbSBEZWVwYWsgUwo+PiBvbiBhdm9pZGluZyBwdW5pdCBhY2Nlc3Mg b24gQ2hlcnJ5dmlldyBhbmQgdGh1cyBpdCB3YXMgZXhjbHVkZWQgb24KPj4gY29tbW9uIHJlY2xv Y2tpbmcgcGF0aC4gQnkgdGFraW5nIHRoZSBzYW1lIGFwcHJvYWNoIGFuZCBvbWl0dGluZwo+PiB0 aGUgcHVuaXQgYWNjZXNzIGJ5IG5vdCB0d2Vha2luZyB0aGUgdGhyZXNob2xkcyB3aGVuIHRoZSBo YXJkd2FyZQo+PiBoYXMgYmVlbiBhc2tlZCB0byBtb3ZlIGludG8gZGlmZmVyZW50IGZyZXF1ZW5j eSwgY29uc2lkZXJhYmxlIGdhaW5zCj4+IGluIHN0YWJpbGl0eSBoYXZlIGJlZW4gb2JzZXJ2ZWQu Cj4+IAo+PiBXaXRoIEoxOTAwIGJveCwgbGlnaHQgcmVuZGVyL3ZpZGVvIGxvYWQgd291bGQgZW5k IHVwIGluIHN5c3RlbSBoYW5nCj4+IGluIHVzdWFsbHkgbGVzcyB0aGFuIDEyIGhvdXJzLiBXaXRo IHRoaXMgcGF0Y2ggYXBwbGllZCwgdGhlIGN1bXVsYXRpdmUKPj4gdXB0aW1lIGhhcyBub3cgYmVl biAzNCBkYXlzIHdpdGhvdXQgaXNzdWVzLiBUbyBwcm92b2tlIHN5c3RlbSBoYW5nLAo+PiBsaWdo dCBsb2FkcyBvbiBib3RoIHJlbmRlciBhbmQgYnNkIGVuZ2luZXMgaW4gcGFyYWxsZWwgaGF2ZSBi ZWVuIHVzZWQ6Cj4+IGdseGdlYXJzID4vZGV2L251bGwgMj4vZGV2L251bGwgJgo+PiBtcHYgLS12 bz12YWFwaSAtLWh3ZGVjPXZhYXBpIC0tbG9vcD1pbmYgdmlkLm1wNAo+PiAKPj4gU28gZmFyLCBh dXRob3IgaGFzIG5vdCB3aXRuZXNzZWQgc3lzdGVtIGhhbmcgd2l0aCBhYm92ZSBsb2FkCj4+IGFu ZCB0aGlzIHBhdGNoIGFwcGxpZWQuIFJlcG9ydHMgZnJvbSB0aGUgdGVuYWNpb3VzIHBlb3BsZSBh dAo+PiBrZXJuZWwgYnVnemlsbGEgYXJlIGFsc28gcHJvbWlzaW5nLgo+PiAKPj4gQ29uc2lkZXJp bmcgdGhhdCB0aGUgcHVuaXQgYWNjZXNzIGZyZXF1ZW5jeSB3aXRoIHRoaXMgcGF0Y2ggaXMKPj4g Y29uc2lkZXJhYmx5IGxlc3MsIHRoZXJlIGlzIGEgcG9zc2liaWxpdHkgdGhhdCB0aGlzIHdpbGwg cHVzaAo+PiB0aGUsIHN0aWxsIHVua25vd24sIHJvb3QgY2F1c2UgcGFzdCB0aGUgdHJpZ2dlcmlu ZyBwb2ludCBvbiBtb3N0IGxvYWRzLgo+PiAKPj4gQnV0IGFzIHdlIG5vdyBjYW4gcmVsaWFibHkg cmVwcm9kdWNlIHRoZSBoYW5nIGluZGVwZW5kZW50bHksCj4+IHdlIGNhbiByZWR1Y2UgdGhlIHBh aW4gdGhhdCB1c2VycyBhcmUgaGF2aW5nIGFuZCB1c2UgYQo+PiBzdGF0aWMgdGhyZXNob2xkcyB1 bnRpbCBhIHJvb3QgY2F1c2UgaXMgZm91bmQuCj4+IAo+PiB2MzogZG9uJ3QgYnJlYWsgZGVidWdm cyBhbmQgc2ltcGxpZmljYXRpb24gKENocmlzIFdpbHNvbikKPj4gCj4+IFJlZmVyZW5jZXM6IGh0 dHBzOi8vYnVnemlsbGEua2VybmVsLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5MDUxCj4+IENjOiBD aHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4gQ2M6IFZpbGxlIFN5cmrD pGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4+IENjOiBMZW4gQnJvd24gPGxl bi5icm93bkBpbnRlbC5jb20+Cj4+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZm d2xsLmNoPgo+PiBDYzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPj4gQ2M6 IGZyaXRzY2hAeGJtYy5vcmcKPj4gQ2M6IG1pa3VAaWtpLmZpCj4+IENjOiBFemVxdWllbCBHYXJj aWEgPGV6ZXF1aWVsQHZhbmd1YXJkaWFzdXIuY29tLmFyPgo+PiBDQzogTWljaGFsIEZlaXggPG1p Y2hhbEBmZWl4LmN6Pgo+PiBDYzogSGFucyBkZSBHb2VkZSA8aGRlZ29lZGVAcmVkaGF0LmNvbT4K Pj4gQ2M6IERlZXBhayBTIDxkZWVwYWsuc0BsaW51eC5pbnRlbC5jb20+Cj4+IENjOiBKYXJra28g TmlrdWxhIDxqYXJra28ubmlrdWxhQGxpbnV4LmludGVsLmNvbT4KPj4gQ2M6IDxzdGFibGVAdmdl ci5rZXJuZWwub3JnPiAjIHY0LjIrCj4+IEFja2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwu dmV0dGVyQGZmd2xsLmNoPgo+PiBTaWduZWQtb2ZmLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1 b3BwYWxhQGludGVsLmNvbT4KPgo+IEhhZCBhIGNvdXBsZSBvZiB3ZWVrZW5kcyB0byB0cnkgYW5k IGZpbmQgYW4gYWx0ZXJuYXRpdmUgZXhwbGFuYXRpb24KPiAoYSByb290IGNhdXNlIGZvciB0aGUg aGFuZ3Mgd291bGQgYmUgbmljZSEpLiBJZiBpdCBpcyBqdXN0IHRoZSB3cml0ZXMgdG8KPiB0aGUg UlBTIHJlZ2lzdGVycywgYXJlIHdlIHNhZmUgb24gcmVzdW1lIChldGMpPwo+Cj4gSG93ZXZlciwg SSd2ZSBkcmF3biBhIGJsYW5rIG9uIGV4cGxhaW5pbmcgd2hhdCB0aGUgaHcgaXMgZG9pbmcgd3Jv bmcKPiAoYnV0IGZvdW5kIGEgY291cGxlIG9mIGJ1Z3MgaW4gdGhlIGJ5dCBtYW51YWwgUlBTIGV2 YWx1YXRpb24gd2hpY2gKPiBkZXNpcmUgcmV2aWV3KSwgc28KPiBBY2tlZC1ieTogQ2hyaXMgV2ls c29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+CgpQdXNoZWQsIHRoYW5rcy4KLU1pa2EKCj4g LUNocmlzCj4KPiAtLSAKPiBDaHJpcyBXaWxzb24sIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xv Z3kgQ2VudHJlCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com ([134.134.136.20]:11723 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbdB0NYl (ORCPT ); Mon, 27 Feb 2017 08:24:41 -0500 From: Mika Kuoppala To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Ville =?utf-8?B?U3lyasOkbMOk?= , Len Brown , Daniel Vetter , Jani Nikula , fritsch@xbmc.org, miku@iki.fi, Ezequiel Garcia , Michal Feix , Hans de Goede , Deepak S , Jarkko Nikula , "# v4 . 2+" Subject: Re: [PATCH] drm/i915: Avoid tweaking evaluation thresholds on Baytrail v3 In-Reply-To: <20170227092519.GE13095@nuc-i3427.alporthouse.com> References: <1487162270-14556-1-git-send-email-mika.kuoppala@intel.com> <1487166779-26945-1-git-send-email-mika.kuoppala@intel.com> <20170227092519.GE13095@nuc-i3427.alporthouse.com> Date: Mon, 27 Feb 2017 15:22:28 +0200 Message-ID: <87o9xnbwff.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org List-ID: Chris Wilson writes: > On Wed, Feb 15, 2017 at 03:52:59PM +0200, Mika Kuoppala wrote: >> Certain Baytrails, namely the 4 cpu core variants, have been >> plaqued by spurious system hangs, mostly occurring with light loads. >> >> Multiple bisects by various people point to a commit which changes the >> reclocking strategy for Baytrail to follow its bigger brethen: >> commit 8fb55197e64d ("drm/i915: Agressive downclocking on Baytrail") >> >> There is also a review comment attached to this commit from Deepak S >> on avoiding punit access on Cherryview and thus it was excluded on >> common reclocking path. By taking the same approach and omitting >> the punit access by not tweaking the thresholds when the hardware >> has been asked to move into different frequency, considerable gains >> in stability have been observed. >> >> With J1900 box, light render/video load would end up in system hang >> in usually less than 12 hours. With this patch applied, the cumulative >> uptime has now been 34 days without issues. To provoke system hang, >> light loads on both render and bsd engines in parallel have been used: >> glxgears >/dev/null 2>/dev/null & >> mpv --vo=vaapi --hwdec=vaapi --loop=inf vid.mp4 >> >> So far, author has not witnessed system hang with above load >> and this patch applied. Reports from the tenacious people at >> kernel bugzilla are also promising. >> >> Considering that the punit access frequency with this patch is >> considerably less, there is a possibility that this will push >> the, still unknown, root cause past the triggering point on most loads. >> >> But as we now can reliably reproduce the hang independently, >> we can reduce the pain that users are having and use a >> static thresholds until a root cause is found. >> >> v3: don't break debugfs and simplification (Chris Wilson) >> >> References: https://bugzilla.kernel.org/show_bug.cgi?id=109051 >> Cc: Chris Wilson >> Cc: Ville Syrjälä >> Cc: Len Brown >> Cc: Daniel Vetter >> Cc: Jani Nikula >> Cc: fritsch@xbmc.org >> Cc: miku@iki.fi >> Cc: Ezequiel Garcia >> CC: Michal Feix >> Cc: Hans de Goede >> Cc: Deepak S >> Cc: Jarkko Nikula >> Cc: # v4.2+ >> Acked-by: Daniel Vetter >> Signed-off-by: Mika Kuoppala > > Had a couple of weekends to try and find an alternative explanation > (a root cause for the hangs would be nice!). If it is just the writes to > the RPS registers, are we safe on resume (etc)? > > However, I've drawn a blank on explaining what the hw is doing wrong > (but found a couple of bugs in the byt manual RPS evaluation which > desire review), so > Acked-by: Chris Wilson Pushed, thanks. -Mika > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre