diff for duplicates of <87o9y17daf.fsf@yhuang-dev.intel.com> diff --git a/a/1.txt b/N1/1.txt index 6d4da8b..25a75ea 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -7,12 +7,12 @@ >> On Thu, 16 Feb 2017, Tim Chen wrote: >>> >>> > I do not understand your zest for putting wrappers around every little ->>> > thing, making it all harder to follow than it need be.A Here's the patch +>>> > thing, making it all harder to follow than it need be. Here's the patch >>> > I've been running with (but you have a leak somewhere, and I don't have >>> > time to search out and fix it: please try sustained swapping and swapoff). >>> > >>> ->>> Hugh, trying to duplicate your test case. A So you were doing swapping, +>>> Hugh, trying to duplicate your test case. So you were doing swapping, >>> then swap off, swap on the swap device and restart swapping? >> >> Repeated pair of make -j20 kernel builds in 700M RAM, 1.5G swap on SSD, @@ -45,3 +45,27 @@ Best Regards, Huang, Ying -----------------------------------------------------> +>From 943494339bd5bc321b8f36f286bc143ac437719b Mon Sep 17 00:00:00 2001 +From: Huang Ying <ying.huang@intel.com> +Date: Fri, 17 Feb 2017 10:31:37 +0800 +Subject: [PATCH] Debug memory leak + +--- + mm/swap_state.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/mm/swap_state.c b/mm/swap_state.c +index 2126e9ba23b2..473b71e052a8 100644 +--- a/mm/swap_state.c ++++ b/mm/swap_state.c +@@ -333,7 +333,7 @@ struct page *__read_swap_cache_async(swp_entry_t entry, gfp_t gfp_mask, + * else swap_off will be aborted if we return NULL. + */ + if (!__swp_swapcount(entry) && swap_slot_cache_enabled) +- return NULL; ++ break; + + /* + * Get a new page to read into from swap. +-- +2.11.0 diff --git a/a/content_digest b/N1/content_digest index cafe5e4..5fd745f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -7,14 +7,14 @@ "From\0Huang\\, Ying <ying.huang@intel.com>\0" "Subject\0Re: swap_cluster_info lockdep splat\0" "Date\0Fri, 17 Feb 2017 10:37:44 +0800\0" - "To\0Huang" + "To\0Huang\\" " Ying <ying.huang@intel.com>\0" "Cc\0Hugh Dickins <hughd@google.com>" Tim Chen <tim.c.chen@linux.intel.com> Minchan Kim <minchan@kernel.org> Andrew Morton <akpm@linux-foundation.org> - linux-kernel@vger.kernel.org - " linux-mm@kvack.org\0" + <linux-kernel@vger.kernel.org> + " <linux-mm@kvack.org>\0" "\00:1\0" "b\0" "\"Huang, Ying\" <ying.huang@intel.com> writes:\n" @@ -26,12 +26,12 @@ ">> On Thu, 16 Feb 2017, Tim Chen wrote:\n" ">>> \n" ">>> > I do not understand your zest for putting wrappers around every little\n" - ">>> > thing, making it all harder to follow than it need be.A Here's the patch\n" + ">>> > thing, making it all harder to follow than it need be.\302\240 Here's the patch\n" ">>> > I've been running with (but you have a leak somewhere, and I don't have\n" ">>> > time to search out and fix it: please try sustained swapping and swapoff).\n" ">>> > \n" ">>> \n" - ">>> Hugh, trying to duplicate your test case. A So you were doing swapping,\n" + ">>> Hugh, trying to duplicate your test case. \302\240So you were doing swapping,\n" ">>> then swap off, swap on the swap device and restart swapping?\n" ">>\n" ">> Repeated pair of make -j20 kernel builds in 700M RAM, 1.5G swap on SSD,\n" @@ -63,6 +63,30 @@ "Best Regards,\n" "Huang, Ying\n" "\n" - -----------------------------------------------------> + "----------------------------------------------------->\n" + ">From 943494339bd5bc321b8f36f286bc143ac437719b Mon Sep 17 00:00:00 2001\n" + "From: Huang Ying <ying.huang@intel.com>\n" + "Date: Fri, 17 Feb 2017 10:31:37 +0800\n" + "Subject: [PATCH] Debug memory leak\n" + "\n" + "---\n" + " mm/swap_state.c | 2 +-\n" + " 1 file changed, 1 insertion(+), 1 deletion(-)\n" + "\n" + "diff --git a/mm/swap_state.c b/mm/swap_state.c\n" + "index 2126e9ba23b2..473b71e052a8 100644\n" + "--- a/mm/swap_state.c\n" + "+++ b/mm/swap_state.c\n" + "@@ -333,7 +333,7 @@ struct page *__read_swap_cache_async(swp_entry_t entry, gfp_t gfp_mask,\n" + " \t\t * else swap_off will be aborted if we return NULL.\n" + " \t\t */\n" + " \t\tif (!__swp_swapcount(entry) && swap_slot_cache_enabled)\n" + "-\t\t\treturn NULL;\n" + "+\t\t\tbreak;\n" + " \n" + " \t\t/*\n" + " \t\t * Get a new page to read into from swap.\n" + "-- \n" + 2.11.0 -0f403b43235dd3215f2030045eef4f799e3080ee658e2c18fb471a6dd7613542 +d830b7ad8aae963e425a8be73d01e39fec31a9ef4bf7a2baf3aacb8d4eb0f315
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.