From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38059)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1c2g8X-0008US-QV
	for qemu-devel@nongnu.org; Fri, 04 Nov 2016 11:10:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1c2g8U-0008RX-LX
	for qemu-devel@nongnu.org; Fri, 04 Nov 2016 11:10:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32788)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1c2g8U-0008Pj-Fx
	for qemu-devel@nongnu.org; Fri, 04 Nov 2016 11:10:30 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1477705687-31175-1-git-send-email-ehabkost@redhat.com>
	<1477705687-31175-2-git-send-email-ehabkost@redhat.com>
	<87k2cj8p6m.fsf@dusky.pond.sub.org>
Date: Fri, 04 Nov 2016 16:10:27 +0100
In-Reply-To: <87k2cj8p6m.fsf@dusky.pond.sub.org> (Markus Armbruster's message
	of "Fri, 04 Nov 2016 12:22:41 +0100")
Message-ID: <87oa1v5li4.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v4 1/8] tests: check-qom-proplist: Remove
 duplicate "bv" property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>

Markus Armbruster <armbru@redhat.com> writes:

> Eduardo Habkost <ehabkost@redhat.com> writes:
>
>> The object_property_add_bool() call in dummy_init() is always
>> failing because there is an existing "bv" class property. We need
>> to remove either the "bv" class property or the "bv" instance
>> property.
>>
>> Remove the class property so both object properties and class
>> properties are covered by the test code.
>>
>> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>
> I accidentally reviewed an older version of this patch.  Just in case:
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
> The multiple colons in the subject are a bit odd.  Suggest
> "tests/check-qom-proplist:".

One more thing: you could test that adding a duplicate property fails.