From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bm0x9-0000y8-IO for qemu-devel@nongnu.org; Mon, 19 Sep 2016 11:57:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bm0x3-0007W2-L5 for qemu-devel@nongnu.org; Mon, 19 Sep 2016 11:57:54 -0400 Received: from mail-yw0-x244.google.com ([2607:f8b0:4002:c05::244]:33528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bm0x3-0007Vs-Eu for qemu-devel@nongnu.org; Mon, 19 Sep 2016 11:57:49 -0400 Received: by mail-yw0-x244.google.com with SMTP id g192so8473164ywh.0 for ; Mon, 19 Sep 2016 08:57:49 -0700 (PDT) References: <20160917140349.12431-1-bobby.prani@gmail.com> From: Pranith Kumar In-reply-to: Date: Mon, 19 Sep 2016 11:57:47 -0400 Message-ID: <87oa3j7uh0.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3 0/6] Clean up TCG tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, alex.bennee@linaro.org, rth@twiddle.net Hi Marc, Marc-André Lureau writes: > Hi Pranith > > On Sat, Sep 17, 2016 at 6:05 PM Pranith Kumar wrote: > >> Hello, >> >> This patch series cleans up the tcg tests in tests/tcg folder. >> >> > Incidentally, I was also looking at reorganizing tests/tcg last week. I > think your series brings some necessary improvements, but it will probably > need more iterations before it is accepted. Could you split off your > obvious changes, such as test build fixes? I think it would help to get > those out of the way first (cc -trivial). Also it would help if you > documented the makefile changes. OK, I will split up the patches into trivial fixes and document the changes to Makefiles. > > >> The tests have bit-rotten and were not compiling or running. I fixed >> the Makefiles to make them compile but there are tests which do not >> pass. >> >> The motivation is to add litmus tests to each arch and have them run >> using the 'make check' target to test consistency on TCG. >> >> There are no maintainers listed for this test folder. So I am cc'ing >> people who I think might be interested. >> >> As suggested by rth in v1 posting, I hooked up 'tests-tcg' target to >> run native tests. Detecting cross compilers or running the tests >> in docker containers are suggested ideas to make running the tests >> easier. >> > > It doesn't make much sense to me to run only native tests (the uname -p), > could you explain the rationale? Instead, I would check what > cross-compilers and qemu targets are available to run the appropriate tests. > Detecting cross compilers is not perfect right now, so I hooked up only the native tests. If you know of a reliable way to detect the presence of cross compilers, please let me know :) Cross compilation tests are supposed to be called by providing a CROSS_CC env variable populated with the installed cross compiler from the build/-linux-user/tests/ directory (as documented in the arm Makefile header). I did not touch the make files for most archs which already had the cross compiler hard-coded. I can modify them to make them similar to what I did for ARM. -- Pranith