diff for duplicates of <87oa3qefac.fsf@kamboji.qca.qualcomm.com> diff --git a/a/1.txt b/N1/1.txt index 857746d..d8736b0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -9,68 +9,69 @@ greearb@candelatech.com writes: Don't tracing points already provide the same information? -> +void ath10k_dbg_print_fw_dbg_buffer(struct ath10k *ar, __le32 *ibuf, int len, +> +void ath10k_dbg_print_fw_dbg_buffer(struct ath10k *ar, __le32 *ibuf, int= + len, > + const char* lvl) > +{ > + /* Print out raw hex, external tools can decode if > + * they care. > + * TODO: Add ar identifier to messages. > + */ -> + int q = 0; +> + int q =3D 0; > + > + dev_printk(lvl, ar->dev, "ath10k_pci ATH10K_DBG_BUFFER:\n"); > + while (q < len) { -> + if (q + 8 <= len) { +> + if (q + 8 <=3D len) { > + printk("%sath10k: [%04d]: %08X %08X %08X %08X %08X %08X %08X %08X\n", > + lvl, q, > + ibuf[q], ibuf[q+1], ibuf[q+2], ibuf[q+3], > + ibuf[q+4], ibuf[q+5], ibuf[q+6], ibuf[q+7]); -> + q += 8; +> + q +=3D 8; > + } -> + else if (q + 7 <= len) { +> + else if (q + 7 <=3D len) { > + printk("%sath10k: [%04d]: %08X %08X %08X %08X %08X %08X %08X\n", > + lvl, q, > + ibuf[q], ibuf[q+1], ibuf[q+2], ibuf[q+3], > + ibuf[q+4], ibuf[q+5], ibuf[q+6]); -> + q += 7; +> + q +=3D 7; > + } -> + else if (q + 6 <= len) { +> + else if (q + 6 <=3D len) { > + printk("%sath10k: [%04d]: %08X %08X %08X %08X %08X %08X\n", > + lvl, q, > + ibuf[q], ibuf[q+1], ibuf[q+2], ibuf[q+3], > + ibuf[q+4], ibuf[q+5]); -> + q += 6; +> + q +=3D 6; > + } -> + else if (q + 5 <= len) { +> + else if (q + 5 <=3D len) { > + printk("%sath10k: [%04d]: %08X %08X %08X %08X %08X\n", > + lvl, q, > + ibuf[q], ibuf[q+1], ibuf[q+2], ibuf[q+3], > + ibuf[q+4]); -> + q += 5; +> + q +=3D 5; > + } -> + else if (q + 4 <= len) { +> + else if (q + 4 <=3D len) { > + printk("%sath10k: [%04d]: %08X %08X %08X %08X\n", > + lvl, q, > + ibuf[q], ibuf[q+1], ibuf[q+2], ibuf[q+3]); -> + q += 4; +> + q +=3D 4; > + } -> + else if (q + 3 <= len) { +> + else if (q + 3 <=3D len) { > + printk("%sath10k: [%04d]: %08X %08X %08X\n", > + lvl, q, > + ibuf[q], ibuf[q+1], ibuf[q+2]); -> + q += 3; +> + q +=3D 3; > + } -> + else if (q + 2 <= len) { +> + else if (q + 2 <=3D len) { > + printk("%sath10k: [%04d]: %08X %08X\n", > + lvl, q, > + ibuf[q], ibuf[q+1]); -> + q += 2; +> + q +=3D 2; > + } -> + else if (q + 1 <= len) { +> + else if (q + 1 <=3D len) { > + printk("%sath10k: [%04d]: %08X\n", > + lvl, q, > + ibuf[q]); -> + q += 1; +> + q +=3D 1; > + } > + else { > + break; @@ -82,9 +83,5 @@ Don't tracing points already provide the same information? Isn't this almost the same as what ath10k_dbg_dump() does? --- -Kalle Valo -_______________________________________________ -ath10k mailing list -ath10k@lists.infradead.org -http://lists.infradead.org/mailman/listinfo/ath10k +--=20 +Kalle Valo= diff --git a/a/content_digest b/N1/content_digest index 65bb205..305b4fc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,8 +4,8 @@ "Subject\0Re: [PATCH v2 09/21] ath10k: print fw debug messages in hex.\0" "Date\0Wed, 14 Sep 2016 14:18:05 +0000\0" "To\0greearb@candelatech.com <greearb@candelatech.com>\0" - "Cc\0linux-wireless@vger.kernel.org <linux-wireless@vger.kernel.org>" - " ath10k@lists.infradead.org <ath10k@lists.infradead.org>\0" + "Cc\0ath10k@lists.infradead.org <ath10k@lists.infradead.org>" + " linux-wireless@vger.kernel.org <linux-wireless@vger.kernel.org>\0" "\00:1\0" "b\0" "greearb@candelatech.com writes:\n" @@ -19,68 +19,69 @@ "\n" "Don't tracing points already provide the same information?\n" "\n" - "> +void ath10k_dbg_print_fw_dbg_buffer(struct ath10k *ar, __le32 *ibuf, int len,\n" + "> +void ath10k_dbg_print_fw_dbg_buffer(struct ath10k *ar, __le32 *ibuf, int=\n" + " len,\n" "> +\t\t\t\t const char* lvl)\n" "> +{\n" "> +\t/* Print out raw hex, external tools can decode if\n" "> +\t * they care.\n" "> +\t * TODO: Add ar identifier to messages.\n" "> +\t */\n" - "> +\tint q = 0;\n" + "> +\tint q =3D 0;\n" "> +\n" "> +\tdev_printk(lvl, ar->dev, \"ath10k_pci ATH10K_DBG_BUFFER:\\n\");\n" "> +\twhile (q < len) {\n" - "> +\t\tif (q + 8 <= len) {\n" + "> +\t\tif (q + 8 <=3D len) {\n" "> +\t\t\tprintk(\"%sath10k: [%04d]: %08X %08X %08X %08X %08X %08X %08X %08X\\n\",\n" "> +\t\t\t lvl, q,\n" "> +\t\t\t ibuf[q], ibuf[q+1], ibuf[q+2], ibuf[q+3],\n" "> +\t\t\t ibuf[q+4], ibuf[q+5], ibuf[q+6], ibuf[q+7]);\n" - "> +\t\t\tq += 8;\n" + "> +\t\t\tq +=3D 8;\n" "> +\t\t}\n" - "> +\t\telse if (q + 7 <= len) {\n" + "> +\t\telse if (q + 7 <=3D len) {\n" "> +\t\t\tprintk(\"%sath10k: [%04d]: %08X %08X %08X %08X %08X %08X %08X\\n\",\n" "> +\t\t\t lvl, q,\n" "> +\t\t\t ibuf[q], ibuf[q+1], ibuf[q+2], ibuf[q+3],\n" "> +\t\t\t ibuf[q+4], ibuf[q+5], ibuf[q+6]);\n" - "> +\t\t\tq += 7;\n" + "> +\t\t\tq +=3D 7;\n" "> +\t\t}\n" - "> +\t\telse if (q + 6 <= len) {\n" + "> +\t\telse if (q + 6 <=3D len) {\n" "> +\t\t\tprintk(\"%sath10k: [%04d]: %08X %08X %08X %08X %08X %08X\\n\",\n" "> +\t\t\t lvl, q,\n" "> +\t\t\t ibuf[q], ibuf[q+1], ibuf[q+2], ibuf[q+3],\n" "> +\t\t\t ibuf[q+4], ibuf[q+5]);\n" - "> +\t\t\tq += 6;\n" + "> +\t\t\tq +=3D 6;\n" "> +\t\t}\n" - "> +\t\telse if (q + 5 <= len) {\n" + "> +\t\telse if (q + 5 <=3D len) {\n" "> +\t\t\tprintk(\"%sath10k: [%04d]: %08X %08X %08X %08X %08X\\n\",\n" "> +\t\t\t lvl, q,\n" "> +\t\t\t ibuf[q], ibuf[q+1], ibuf[q+2], ibuf[q+3],\n" "> +\t\t\t ibuf[q+4]);\n" - "> +\t\t\tq += 5;\n" + "> +\t\t\tq +=3D 5;\n" "> +\t\t}\n" - "> +\t\telse if (q + 4 <= len) {\n" + "> +\t\telse if (q + 4 <=3D len) {\n" "> +\t\t\tprintk(\"%sath10k: [%04d]: %08X %08X %08X %08X\\n\",\n" "> +\t\t\t lvl, q,\n" "> +\t\t\t ibuf[q], ibuf[q+1], ibuf[q+2], ibuf[q+3]);\n" - "> +\t\t\tq += 4;\n" + "> +\t\t\tq +=3D 4;\n" "> +\t\t}\n" - "> +\t\telse if (q + 3 <= len) {\n" + "> +\t\telse if (q + 3 <=3D len) {\n" "> +\t\t\tprintk(\"%sath10k: [%04d]: %08X %08X %08X\\n\",\n" "> +\t\t\t lvl, q,\n" "> +\t\t\t ibuf[q], ibuf[q+1], ibuf[q+2]);\n" - "> +\t\t\tq += 3;\n" + "> +\t\t\tq +=3D 3;\n" "> +\t\t}\n" - "> +\t\telse if (q + 2 <= len) {\n" + "> +\t\telse if (q + 2 <=3D len) {\n" "> +\t\t\tprintk(\"%sath10k: [%04d]: %08X %08X\\n\",\n" "> +\t\t\t lvl, q,\n" "> +\t\t\t ibuf[q], ibuf[q+1]);\n" - "> +\t\t\tq += 2;\n" + "> +\t\t\tq +=3D 2;\n" "> +\t\t}\n" - "> +\t\telse if (q + 1 <= len) {\n" + "> +\t\telse if (q + 1 <=3D len) {\n" "> +\t\t\tprintk(\"%sath10k: [%04d]: %08X\\n\",\n" "> +\t\t\t lvl, q,\n" "> +\t\t\t ibuf[q]);\n" - "> +\t\t\tq += 1;\n" + "> +\t\t\tq +=3D 1;\n" "> +\t\t}\n" "> +\t\telse {\n" "> +\t\t\tbreak;\n" @@ -92,11 +93,7 @@ "\n" "Isn't this almost the same as what ath10k_dbg_dump() does?\n" "\n" - "-- \n" - "Kalle Valo\n" - "_______________________________________________\n" - "ath10k mailing list\n" - "ath10k@lists.infradead.org\n" - http://lists.infradead.org/mailman/listinfo/ath10k + "--=20\n" + Kalle Valo= -cb2395d4b2634c4c3346f07bdec08337c8e30cd2b87187e7c0586e728be759ff +fb25d2d1c553a49a482448e22dc9b0318cef5efb3fe1aa8844388be0cf6827ac
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.