From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37440)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bPQ94-0005kw-Cq
	for qemu-devel@nongnu.org; Tue, 19 Jul 2016 04:12:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bPQ8y-0006pc-0z
	for qemu-devel@nongnu.org; Tue, 19 Jul 2016 04:12:47 -0400
Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]:38760)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bPQ8x-0006pK-Jo
	for qemu-devel@nongnu.org; Tue, 19 Jul 2016 04:12:43 -0400
Received: by mail-wm0-x233.google.com with SMTP id o80so16537212wme.1
	for <qemu-devel@nongnu.org>; Tue, 19 Jul 2016 01:12:43 -0700 (PDT)
References: <1468335639-24582-1-git-send-email-alex.bennee@linaro.org>
	<87shv7ndlo.fsf@linaro.org>
	<20160719074047.GJ18103@ad.usersys.redhat.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <20160719074047.GJ18103@ad.usersys.redhat.com>
Date: Tue, 19 Jul 2016 09:12:44 +0100
Message-ID: <87oa5um4g3.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v5 0/7] docker: Support building qemu-user
 powered docker test images
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, riku.voipio@linaro.org


Fam Zheng <famz@redhat.com> writes:

> On Mon, 07/18 16:57, Alex Bennée wrote:
>> > So any ideas about that?
>
> Hi Alex,
>
> Sorry for the late reply.
>
>>
>> Any thoughts on that Fam? Can we merge it without the final step on the
>> grounds it makes for useful testing?
>
> Yes, we can, though I'd like to make sure we don't break existing docker tests.
> Specifically we need to skip building and spawning the debian-bootstrap image
> if its dependencies are not met. To do that we can define a magic exit code for
> .pre scripts, and catch it in docker.py.

It does exit if the pre-reqs aren't met, I guess we could default the
DEB_ARCH/DEB_TYPE as well.

>
> What do you think?
>
> Fam
>
>>
>> >
>> > Alex Bennée (5):
>> >   tests/docker/docker.py: docker_dir outside build
>> >   tests/docker/docker.py: support --include-executable
>> >   tests/docker/docker.py: check and run .pre script
>> >   tests/docker/dockerfiles: new debian-bootstrap.docker
>> >   tests/docker/docker.py: add update operation
>> >
>> > Fam Zheng (2):
>> >   docker: More sensible run script
>> >   docker: Fix exit code if $CMD failed
>> >
>> >  tests/docker/Makefile.include                    |   4 +-
>> >  tests/docker/docker.py                           | 144 +++++++++++++++++++++--
>> >  tests/docker/dockerfiles/debian-bootstrap.docker |  21 ++++
>> >  tests/docker/dockerfiles/debian-bootstrap.pre    |  82 +++++++++++++
>> >  tests/docker/run                                 |  16 ++-
>> >  5 files changed, 252 insertions(+), 15 deletions(-)
>> >  create mode 100644 tests/docker/dockerfiles/debian-bootstrap.docker
>> >  create mode 100755 tests/docker/dockerfiles/debian-bootstrap.pre
>>
>>
>> --
>> Alex Bennée
>>


--
Alex Bennée