From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46122)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bLPhq-0000oE-OJ
	for qemu-devel@nongnu.org; Fri, 08 Jul 2016 02:56:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bLPhm-0005IW-Lp
	for qemu-devel@nongnu.org; Fri, 08 Jul 2016 02:56:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46845)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bLPhm-0005IS-GX
	for qemu-devel@nongnu.org; Fri, 08 Jul 2016 02:56:06 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id CE9707F352
	for <qemu-devel@nongnu.org>; Fri,  8 Jul 2016 06:56:05 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <1467906798-5312-1-git-send-email-pbonzini@redhat.com>
	<1467906798-5312-2-git-send-email-pbonzini@redhat.com>
	<87twg1fm52.fsf@dusky.pond.sub.org>
	<1084721995.4983100.1467909863450.JavaMail.zimbra@redhat.com>
Date: Fri, 08 Jul 2016 08:56:03 +0200
In-Reply-To: <1084721995.4983100.1467909863450.JavaMail.zimbra@redhat.com>
	(Paolo Bonzini's message of "Thu, 7 Jul 2016 12:44:23 -0400 (EDT)")
Message-ID: <87oa68d3ek.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v3 1/2] qapi: change QmpOutputVisitor to
 QSLIST
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

Paolo Bonzini <pbonzini@redhat.com> writes:

>> >  struct QmpOutputVisitor
>> >  {
>> >      Visitor visitor;
>> > -    QStack stack; /* Stack of containers that haven't yet been finished */
>> > +    QSLIST_HEAD(, QStackEntry) stack; /* Stack of containers that haven't
>> > yet been finished */
>> 
>> Long line.  I'll squash in Eric's proposed fix on commit if you don't
>> mind:
>> 
>>        QSLIST_HEAD(...);           /* Stack of unfinished containers */
>
> Yes, of course, sorry for forgetting about it.

No problem at all :)