From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKnq7-0002Yj-KP for qemu-devel@nongnu.org; Wed, 06 Jul 2016 10:30:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKnq2-0003Dj-OQ for qemu-devel@nongnu.org; Wed, 06 Jul 2016 10:30:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKnq2-0003Db-IH for qemu-devel@nongnu.org; Wed, 06 Jul 2016 10:30:06 -0400 From: Markus Armbruster References: <1467636059-12557-1-git-send-email-pbonzini@redhat.com> Date: Wed, 06 Jul 2016 16:30:03 +0200 In-Reply-To: <1467636059-12557-1-git-send-email-pbonzini@redhat.com> (Paolo Bonzini's message of "Mon, 4 Jul 2016 14:40:59 +0200") Message-ID: <87oa6adel0.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] json-streamer: fix double-free on exiting during a parse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, xiecl.fnst@cn.fujitsu.com Paolo Bonzini writes: > Now that json-streamer tries not to leak tokens on incomplete parse, > the tokens can be freed twice if QEMU destroys the json-streamer > object during the parser->emit call. To fix this, create the new > empty GQueue earlier, so that it is already in place when the old > one is passed to parser->emit. > > Reported-by: Changlong Xie > Signed-off-by: Paolo Bonzini Reviewed-by: Markus Armbruster Want me to do the pull request?