From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33137)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bGMEN-0003Ap-5S
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 04:12:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bGMEH-0000zw-9q
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 04:12:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49479)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bGMEH-0000zs-3f
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 04:12:45 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1466698330-6021-1-git-send-email-armbru@redhat.com>
	<1466698330-6021-5-git-send-email-armbru@redhat.com>
	<CAFEAcA9Oz2hjQEM3m6y=uonC5KQkbin67=e5ZS+EeZC-Pd5Wyg@mail.gmail.com>
Date: Fri, 24 Jun 2016 10:12:42 +0200
In-Reply-To: <CAFEAcA9Oz2hjQEM3m6y=uonC5KQkbin67=e5ZS+EeZC-Pd5Wyg@mail.gmail.com>
	(Peter Maydell's message of "Thu, 23 Jun 2016 17:41:48 +0100")
Message-ID: <87oa6rxax1.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH RFC 4/5] include: Move typedef qemu_irq to
 qemu/typedefs.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>

Peter Maydell <peter.maydell@linaro.org> writes:

> On 23 June 2016 at 17:12, Markus Armbruster <armbru@redhat.com> wrote:
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  include/hw/irq.h        | 2 --
>>  include/qemu/typedefs.h | 1 +
>>  tests/Makefile.include  | 2 --
>>  3 files changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/include/hw/irq.h b/include/hw/irq.h
>> index 4c4c2ea..6a89571 100644
>> --- a/include/hw/irq.h
>> +++ b/include/hw/irq.h
>> @@ -5,8 +5,6 @@
>>
>>  #define TYPE_IRQ "irq"
>>
>> -typedef struct IRQState *qemu_irq;
>> -
>>  typedef void (*qemu_irq_handler)(void *opaque, int n, int level);
>>
>>  void qemu_set_irq(qemu_irq irq, int level);
>> diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
>> index f9745c4..f7c27a9 100644
>> --- a/include/qemu/typedefs.h
>> +++ b/include/qemu/typedefs.h
>> @@ -31,6 +31,7 @@ typedef struct FWCfgState FWCfgState;
>>  typedef struct HCIInfo HCIInfo;
>>  typedef struct I2CBus I2CBus;
>>  typedef struct I2SCodec I2SCodec;
>> +typedef struct IRQState *qemu_irq;
>>  typedef struct ISABus ISABus;
>>  typedef struct ISADevice ISADevice;
>>  typedef struct IsaDma IsaDma;
>
> Everything else in typedefs.h is a "typedef struct Thing Thing",
> but qemu_irq is different...

We want to keep our readers on their toes!