From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52392)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1bEwpS-0006Ry-2a
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 06:53:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1bEwpN-0008Vh-Sq
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 06:53:17 -0400
Received: from roura.ac.upc.es ([147.83.33.10]:59349)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1bEwpN-0008VU-Hr
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 06:53:13 -0400
From: =?utf-8?Q?Llu=C3=ADs_Vilanova?= <vilanova@ac.upc.edu>
References: <146590985033.16561.16324808287190305042.stgit@fimbulvetr.bsc.es>
	<146590988276.16561.7454935023049676591.stgit@fimbulvetr.bsc.es>
	<87y460coi6.fsf@dusky.pond.sub.org>
Date: Mon, 20 Jun 2016 12:53:11 +0200
In-Reply-To: <87y460coi6.fsf@dusky.pond.sub.org> (Markus Armbruster's message
	of "Mon, 20 Jun 2016 09:23:29 +0200")
Message-ID: <87oa6wt9m0.fsf@fimbulvetr.bsc.es>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 6/6] trace: Add QAPI/QMP interfaces to
 query and control per-vCPU tracing state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>

Markus Armbruster writes:

> Llu=C3=ADs Vilanova <vilanova@ac.upc.edu> writes:
>> Signed-off-by: Llu=C3=ADs Vilanova <vilanova@ac.upc.edu>
>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>> monitor.c       |    4 +-
>> qapi/trace.json |   20 ++++++--
>> qmp-commands.hx |   17 ++++++-
>> trace/qmp.c     |  143 ++++++++++++++++++++++++++++++++++++++++++++-----=
------
>> 4 files changed, 147 insertions(+), 37 deletions(-)
>>=20
>> diff --git a/monitor.c b/monitor.c
>> index a27e115..bb89877 100644
>> --- a/monitor.c
>> +++ b/monitor.c
>> @@ -910,7 +910,7 @@ static void hmp_trace_event(Monitor *mon, const QDic=
t *qdict)
>> bool new_state =3D qdict_get_bool(qdict, "option");
>> Error *local_err =3D NULL;
>>=20
>> -    qmp_trace_event_set_state(tp_name, new_state, true, true, &local_er=
r);
>> +    qmp_trace_event_set_state(tp_name, new_state, true, true, false, 0,=
 &local_err);
>> if (local_err) {
>> error_report_err(local_err);
>> }
>> @@ -1069,7 +1069,7 @@ static void hmp_info_cpustats(Monitor *mon, const =
QDict *qdict)
>>=20
>> static void hmp_info_trace_events(Monitor *mon, const QDict *qdict)
>> {
>> -    TraceEventInfoList *events =3D qmp_trace_event_get_state("*", NULL);
>> +    TraceEventInfoList *events =3D qmp_trace_event_get_state("*", false=
, 0, NULL);
>> TraceEventInfoList *elem;
>>=20
>> for (elem =3D events; elem !=3D NULL; elem =3D elem->next) {

> The new feature remains inaccessible in HMP.  Any plans to extend HMP?
> Any reasons not to?

BTW, I was just looking at "info trace-events" and it only shows the state =
for
all events (there's no name pattern argument). Is it worth updating HMP kno=
wing
it should be replaced in favour of the newer QAPI interface?


Thanks,
  Lluis