From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49913)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bCmOL-0007Kf-1D
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 07:20:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bCmOH-0007Ms-3b
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 07:20:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55034)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bCmOG-0007Mo-Tq
	for qemu-devel@nongnu.org; Tue, 14 Jun 2016 07:20:17 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 6845A37E62
	for <qemu-devel@nongnu.org>; Tue, 14 Jun 2016 11:20:16 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <1465855078-19435-1-git-send-email-ehabkost@redhat.com>
	<1465855078-19435-4-git-send-email-ehabkost@redhat.com>
	<87d1nkkv07.fsf@dusky.pond.sub.org>
	<a9bac517-fc4a-1220-e05d-e9e0de512ef8@redhat.com>
Date: Tue, 14 Jun 2016 13:20:14 +0200
In-Reply-To: <a9bac517-fc4a-1220-e05d-e9e0de512ef8@redhat.com> (Paolo
	Bonzini's message of "Tue, 14 Jun 2016 11:11:42 +0200")
Message-ID: <87oa74f24x.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v3 3/3] coccinelle: Remove unnecessary
 variables for function return value
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 14/06/2016 10:57, Markus Armbruster wrote:
>>> diff --git a/scripts/coccinelle/return_directly.cocci b/scripts/coccinelle/return_directly.cocci
>>> > new file mode 100644
>>> > index 0000000..c52f4fc
>>> > --- /dev/null
>>> > +++ b/scripts/coccinelle/return_directly.cocci
>>> > @@ -0,0 +1,21 @@
>>> > +// replace 'R = X; return R;' with 'return R;'
>>> > +
>>> > +// remove assignment
>> Second comment feels redundant.  Can drop on commit to error-next.
>> 
>>> > +@ removal @
>> Rule name "removal" is not used.  Can drop on commit to error-next.
>> 
>
> I've seen rule names used as a comment.  Feels a bit like COBOL, but it
> doesn't hurt.  Perhaps rename it to "@ return_directly @"?

No objection.  However, the existing semantic patches in
scripts/coccinelle/ don't do that.  You guys tell me what to do with
this one.