All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/gcc: 4.8.x to 5.x: backport a fix for building gcc with gcc-6
Date: Mon, 16 May 2016 22:59:00 +0200	[thread overview]
Message-ID: <87oa85en3f.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20160516085019.237fbc76@free-electrons.com> (Thomas Petazzoni's message of "Mon, 16 May 2016 08:50:19 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Hello,
 > On Mon, 16 May 2016 06:03:48 +0200, Samuel Martin wrote:
 >> When the host system compiler is gcc-6, this patch is needed to build
 >> Buildroot toolchain and cleanly apply on gcc version 4.8.x to 5.x (not
 >> needed for 4.7.x series).
 >> 
 >> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
 >> 
 >> ---
 >> changes v1->v2:
 >> - rename patches {ThomasP)
 >> ---
 >> package/gcc/4.8.5/130-fix_build_with_gcc-6.patch   | 153 +++++++++++++++++++++
 >> package/gcc/4.9.3/130-fix_build_with_gcc-6.patch   | 153 +++++++++++++++++++++
 >> package/gcc/5.3.0/130-fix_build_with_gcc-6.patch   | 153 +++++++++++++++++++++
 >> .../gcc/arc-2015.12/130-fix_build_with_gcc-6.patch | 153 +++++++++++++++++++++
 >> 4 files changed, 612 insertions(+)
 >> create mode 100644 package/gcc/4.8.5/130-fix_build_with_gcc-6.patch
 >> create mode 100644 package/gcc/4.9.3/130-fix_build_with_gcc-6.patch
 >> create mode 100644 package/gcc/5.3.0/130-fix_build_with_gcc-6.patch
 >> create mode 100644 package/gcc/arc-2015.12/130-fix_build_with_gcc-6.patch

 > Thanks for this new iteration, looks good. Now, I'm wondering whether I
 > should apply this to master or to next.

 > It really is a build fix, so master is normally appropriate. However:

 >  1/ It is touching really a core component, gcc, so we should be more
 >     conservative than for other packages.

 >  2/ There are probably tons of other host packages that don't yet build
 >     with gcc 6, so we might as well decide that Buildroot 2016.05 is
 >     not gcc 6 compatible, and to make it a goal for Buildroot 2016.08
 >     to support gcc 6 on the host.

 > Opinions welcome.

I also would prefer to err on the side of caution. From IRC I see that
so far only Arch has moved to gcc6 by default, so I think we should only
add it in next.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2016-05-16 20:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-16  4:03 [Buildroot] [PATCH v2] package/gcc: 4.8.x to 5.x: backport a fix for building gcc with gcc-6 Samuel Martin
2016-05-16  6:50 ` Thomas Petazzoni
2016-05-16 20:59   ` Peter Korsgaard [this message]
2016-05-17 20:28 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oa85en3f.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.