All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] sysklogd: override SKFLAGS with TARGET_CFLAGS
Date: Sun, 21 Feb 2016 10:21:53 +0100	[thread overview]
Message-ID: <87oababeq6.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <56C8FE2C.1070000@mind.be> (Arnout Vandecappelle's message of "Sun, 21 Feb 2016 01:00:44 +0100")

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

Hi,

 >> +# Override SKFLAGS which is used as CFLAGS.
 >> define SYSKLOGD_BUILD_CMDS
 >> -	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
 >> +	$(MAKE) $(TARGET_CONFIGURE_OPTS) SKFLAGS="$(TARGET_CFLAGS) -DSYSV" \

 >  Doesn't that make the bug above reappear when you have configured
 > BR2_OPTIMIZE_3? In other words, shouldn't we do something like:

 > ifeq ($(BR2_TOOLCHAIN...),y)
 > SYSKLOGD_CFLAGS = $(subst -O3,-O2,$(TARGET_CFLAGS))
 > else
 > SYSKLOGD_CFLAGS = $(TARGET_CFLAGS)
 > endif
 > SYSKLOGD_CFLAGS += -DSYSV

True, but chances are that other packages will be affected by that -O3
issue with the 2012.03, so perhaps the safest option is to make
BR2_OPTIMIZE_3 depend on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC_E500V2.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2016-02-21  9:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-20 11:28 [Buildroot] [PATCH] sysklogd: override SKFLAGS with TARGET_CFLAGS Romain Naour
2016-02-20 20:25 ` Peter Korsgaard
2016-02-21  0:00 ` Arnout Vandecappelle
2016-02-21  9:21   ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oababeq6.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.