From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH 06/11] drm/i915: refactor VBT validation
Date: Mon, 14 Dec 2015 16:34:50 +0200
Message-ID: <87oadtt7xx.fsf@intel.com>
References: <cover.1450089383.git.jani.nikula@intel.com>
 <068ea5809a2ebe1e79aef85bc91d05ef69041f1d.1450089383.git.jani.nikula@intel.com>
 <20151214134141.GI4437@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id 7E4DA6E088
 for <intel-gfx@lists.freedesktop.org>; Mon, 14 Dec 2015 06:34:52 -0800 (PST)
In-Reply-To: <20151214134141.GI4437@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?utf-8?B?U3lyasOkbMOk?= <ville.syrjala@linux.intel.com>
Cc: Deepak M <m.deepak@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCAxNCBEZWMgMjAxNSwgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4
LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gTW9uLCBEZWMgMTQsIDIwMTUgYXQgMTI6NTA6NTBQTSAr
MDIwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4+IE1ha2UgdGhlIHZhbGlkYXRpb24gZnVuY3Rpb24g
YSBib29sZWFuIG9wZXJhdGluZyBvbiBhIGJ1ZmZlciBvZiBnaXZlbgo+PiBzaXplLCByZW1vdmlu
ZyB0aGUgZXh0cmEgcG9pbnRlciBkYW5jZXMuCj4+IAo+PiBNb3ZlIHRoZSBPcFJlZ2lvbiBiYXNl
ZCBWQlQgdmFsaWRhdGlvbiB0byBpbnRlbF9vcHJlZ2lvbl9zZXR1cCgpLCBvbmx5Cj4+IGluaXRp
YWxpemluZyBvcHJlZ2lvbi0+dmJ0IGlmIGl0J3MgdmFsaWQuCj4+IAo+PiBTaWduZWQtb2ZmLWJ5
OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMv
Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICAgfCAgMSArCj4+ICBkcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9iaW9zLmMgICAgIHwgNjMgKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0t
LS0tLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX29wcmVnaW9uLmMgfCAgOSArKyst
LQo+PiAgMyBmaWxlcyBjaGFuZ2VkLCA0MCBpbnNlcnRpb25zKCspLCAzMyBkZWxldGlvbnMoLSkK
Pj4gCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiBpbmRleCBhMmJkNGM2YTg2YTEuLmVmMTVm
MTcxMGI1MCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+
PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+IEBAIC0zMzU0LDYgKzMz
NTQsNyBAQCBleHRlcm4gdm9pZCBpbnRlbF9pMmNfcmVzZXQoc3RydWN0IGRybV9kZXZpY2UgKmRl
dik7Cj4+ICAKPj4gIC8qIGludGVsX2Jpb3MuYyAqLwo+PiAgaW50IGludGVsX2Jpb3NfaW5pdChz
dHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPj4gK2Jvb2wgaW50ZWxfYmlvc19pc192YWxpZF92YnQo
Y29uc3Qgdm9pZCAqYnVmLCBzaXplX3Qgc2l6ZSk7Cj4+ICAKPj4gIC8qIGludGVsX29wcmVnaW9u
LmMgKi8KPj4gICNpZmRlZiBDT05GSUdfQUNQSQo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfYmlvcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5j
Cj4+IGluZGV4IGYyYjc5YjdkMTJiOC4uMDA3YjJiNzU5NjAwIDEwMDY0NAo+PiAtLS0gYS9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfYmlvcy5jCj4+IEBAIC0xMjIxLDM3ICsxMjIxLDQwIEBAIHN0YXRpYyBjb25zdCBz
dHJ1Y3QgYmRiX2hlYWRlciAqZ2V0X2JkYl9oZWFkZXIoY29uc3Qgc3RydWN0IHZidF9oZWFkZXIg
KnZidCkKPj4gIAlyZXR1cm4gX3ZidCArIHZidC0+YmRiX29mZnNldDsKPj4gIH0KPj4gIAo+PiAt
c3RhdGljIGNvbnN0IHN0cnVjdCB2YnRfaGVhZGVyICp2YWxpZGF0ZV92YnQoY29uc3Qgdm9pZCAq
YmFzZSwKPj4gLQkJCQkJICAgICBzaXplX3Qgc2l6ZSwKPj4gLQkJCQkJICAgICBjb25zdCB2b2lk
ICpfdmJ0KQo+PiArLyoqCj4+ICsgKiBpbnRlbF9iaW9zX2lzX3ZhbGlkX3ZidCAtIGRvZXMgdGhl
IGdpdmVuIGJ1ZmZlciBjb250YWluIGEgdmFsaWQgVkJUCj4+ICsgKiBAYnVmOglwb2ludGVyIHRv
IGEgYnVmZmVyIHRvIHZhbGlkYXRlCj4+ICsgKiBAc2l6ZToJc2l6ZSBvZiB0aGUgYnVmZmVyCj4+
ICsgKgo+PiArICogUmV0dXJucyB0cnVlIG9uIHZhbGlkIFZCVC4KPj4gKyAqLwo+PiArYm9vbCBp
bnRlbF9iaW9zX2lzX3ZhbGlkX3ZidChjb25zdCB2b2lkICpidWYsIHNpemVfdCBzaXplKQo+PiAg
ewo+PiAtCXNpemVfdCBvZmZzZXQgPSBfdmJ0IC0gYmFzZTsKPj4gLQljb25zdCBzdHJ1Y3QgdmJ0
X2hlYWRlciAqdmJ0ID0gX3ZidDsKPj4gKwljb25zdCBzdHJ1Y3QgdmJ0X2hlYWRlciAqdmJ0ID0g
YnVmOwo+PiAgCWNvbnN0IHN0cnVjdCBiZGJfaGVhZGVyICpiZGI7Cj4+ICAKPj4gIAlpZiAoIXZi
dCkKPj4gLQkJcmV0dXJuIE5VTEw7Cj4+ICsJCXJldHVybiBmYWxzZTsKPj4gIAo+PiAtCWlmIChv
ZmZzZXQgKyBzaXplb2Yoc3RydWN0IHZidF9oZWFkZXIpID4gc2l6ZSkgewo+PiArCWlmIChzaXpl
b2Yoc3RydWN0IHZidF9oZWFkZXIpID4gc2l6ZSkgewo+PiAgCQlEUk1fREVCVUdfRFJJVkVSKCJW
QlQgaGVhZGVyIGluY29tcGxldGVcbiIpOwo+PiAtCQlyZXR1cm4gTlVMTDsKPj4gKwkJcmV0dXJu
IGZhbHNlOwo+PiAgCX0KPj4gIAo+PiAgCWlmIChtZW1jbXAodmJ0LT5zaWduYXR1cmUsICIkVkJU
IiwgNCkpIHsKPj4gIAkJRFJNX0RFQlVHX0RSSVZFUigiVkJUIGludmFsaWQgc2lnbmF0dXJlXG4i
KTsKPj4gLQkJcmV0dXJuIE5VTEw7Cj4+ICsJCXJldHVybiBmYWxzZTsKPj4gIAl9Cj4+ICAKPj4g
LQlvZmZzZXQgKz0gdmJ0LT5iZGJfb2Zmc2V0Owo+PiAtCWlmIChvZmZzZXQgKyBzaXplb2Yoc3Ry
dWN0IGJkYl9oZWFkZXIpID4gc2l6ZSkgewo+PiArCWlmICh2YnQtPmJkYl9vZmZzZXQgKyBzaXpl
b2Yoc3RydWN0IGJkYl9oZWFkZXIpID4gc2l6ZSkgewo+PiAgCQlEUk1fREVCVUdfRFJJVkVSKCJC
REIgaGVhZGVyIGluY29tcGxldGVcbiIpOwo+PiAtCQlyZXR1cm4gTlVMTDsKPj4gKwkJcmV0dXJu
IGZhbHNlOwo+PiAgCX0KPj4gIAo+PiAgCWJkYiA9IGdldF9iZGJfaGVhZGVyKHZidCk7Cj4+IC0J
aWYgKG9mZnNldCArIGJkYi0+YmRiX3NpemUgPiBzaXplKSB7Cj4+ICsJaWYgKHZidC0+YmRiX29m
ZnNldCArIGJkYi0+YmRiX3NpemUgPiBzaXplKSB7Cj4+ICAJCURSTV9ERUJVR19EUklWRVIoIkJE
QiBpbmNvbXBsZXRlXG4iKTsKPj4gLQkJcmV0dXJuIE5VTEw7Cj4+ICsJCXJldHVybiBmYWxzZTsK
Pj4gIAl9Cj4+ICAKPj4gIAlyZXR1cm4gdmJ0Owo+PiBAQCAtMTI1OSwyNiArMTI2MiwyNyBAQCBz
dGF0aWMgY29uc3Qgc3RydWN0IHZidF9oZWFkZXIgKnZhbGlkYXRlX3ZidChjb25zdCB2b2lkICpi
YXNlLAo+PiAgCj4+ICBzdGF0aWMgY29uc3Qgc3RydWN0IHZidF9oZWFkZXIgKmZpbmRfdmJ0KHZv
aWQgX19pb21lbSAqYmlvcywgc2l6ZV90IHNpemUpCj4+ICB7Cj4+IC0JY29uc3Qgc3RydWN0IHZi
dF9oZWFkZXIgKnZidCA9IE5VTEw7Cj4+ICAJc2l6ZV90IGk7Cj4+ICAKPj4gIAkvKiBTY291ciBt
ZW1vcnkgbG9va2luZyBmb3IgdGhlIFZCVCBzaWduYXR1cmUuICovCj4+ICAJZm9yIChpID0gMDsg
aSArIDQgPCBzaXplOyBpKyspIHsKPj4gLQkJaWYgKGlvcmVhZDMyKGJpb3MgKyBpKSA9PSAqKChj
b25zdCB1MzIgKikgIiRWQlQiKSkgewo+PiAtCQkJLyoKPj4gLQkJCSAqIFRoaXMgaXMgdGhlIG9u
ZSBwbGFjZSB3aGVyZSB3ZSBleHBsaWNpdGx5IGRpc2NhcmQgdGhlCj4+IC0JCQkgKiBhZGRyZXNz
IHNwYWNlIChfX2lvbWVtKSBvZiB0aGUgQklPUy9WQlQuIEZyb20gbm93IG9uCj4+IC0JCQkgKiBl
dmVyeXRoaW5nIGlzIGJhc2VkIG9uICdiYXNlJywgYW5kIHRyZWF0ZWQgYXMgcmVndWxhcgo+PiAt
CQkJICogbWVtb3J5Lgo+PiAtCQkJICovCj4+IC0JCQl2b2lkICpfYmlvcyA9ICh2b2lkIF9fZm9y
Y2UgKikgYmlvczsKPj4gKwkJdm9pZCAqdmJ0Owo+PiAgCj4+IC0JCQl2YnQgPSB2YWxpZGF0ZV92
YnQoX2Jpb3MsIHNpemUsIF9iaW9zICsgaSk7Cj4+IC0JCQlicmVhazsKPj4gLQkJfQo+PiArCQlp
ZiAoaW9yZWFkMzIoYmlvcyArIGkpICE9ICooKGNvbnN0IHUzMiAqKSAiJFZCVCIpKQo+PiArCQkJ
Y29udGludWU7Cj4+ICsKPj4gKwkJLyoKPj4gKwkJICogVGhpcyBpcyB0aGUgb25lIHBsYWNlIHdo
ZXJlIHdlIGV4cGxpY2l0bHkgZGlzY2FyZCB0aGUgYWRkcmVzcwo+PiArCQkgKiBzcGFjZSAoX19p
b21lbSkgb2YgdGhlIEJJT1MvVkJULgo+PiArCQkgKi8KPj4gKwkJdmJ0ID0gKHZvaWQgX19mb3Jj
ZSAqKSBiaW9zICsgaTsKPj4gKwkJaWYgKGludGVsX2Jpb3NfaXNfdmFsaWRfdmJ0KHZidCwgc2l6
ZSAtIGkpKQo+PiArCQkJcmV0dXJuIHZidDsKPj4gKwo+PiArCQlicmVhazsKPj4gIAl9Cj4+ICAK
Pj4gLQlyZXR1cm4gdmJ0Owo+PiArCXJldHVybiBOVUxMOwo+PiAgfQo+PiAgCj4+ICAvKioKPj4g
QEAgLTEyOTUsNyArMTI5OSw3IEBAIGludGVsX2Jpb3NfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAq
ZGV2KQo+PiAgewo+PiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+
ZGV2X3ByaXZhdGU7Cj4+ICAJc3RydWN0IHBjaV9kZXYgKnBkZXYgPSBkZXYtPnBkZXY7Cj4+IC0J
Y29uc3Qgc3RydWN0IHZidF9oZWFkZXIgKnZidDsKPj4gKwljb25zdCBzdHJ1Y3QgdmJ0X2hlYWRl
ciAqdmJ0ID0gZGV2X3ByaXYtPm9wcmVnaW9uLnZidDsKPj4gIAljb25zdCBzdHJ1Y3QgYmRiX2hl
YWRlciAqYmRiOwo+PiAgCXU4IF9faW9tZW0gKmJpb3MgPSBOVUxMOwo+PiAgCj4+IEBAIC0xMzA0
LDkgKzEzMDgsNiBAQCBpbnRlbF9iaW9zX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPj4g
IAo+PiAgCWluaXRfdmJ0X2RlZmF1bHRzKGRldl9wcml2KTsKPj4gIAo+PiAtCS8qIFhYWCBTaG91
bGQgdGhpcyB2YWxpZGF0aW9uIGJlIG1vdmVkIHRvIGludGVsX29wcmVnaW9uLmM/ICovCj4+IC0J
dmJ0ID0gdmFsaWRhdGVfdmJ0KGRldl9wcml2LT5vcHJlZ2lvbi5oZWFkZXIsIE9QUkVHSU9OX1NJ
WkUsCj4+IC0JCQkgICBkZXZfcHJpdi0+b3ByZWdpb24udmJ0KTsKPj4gIAlpZiAodmJ0KSB7Cj4+
ICAJCURSTV9ERUJVR19LTVMoIlVzaW5nIFZCVCBmcm9tIEFDUEkgT3BSZWdpb246ICUyMHNcbiIs
Cj4+ICAJCQkgICAgICB2YnQtPnNpZ25hdHVyZSk7Cj4KPiBNYXliZSB0aGUgZGVidWcgbWVzc2Fn
ZSBzaG91bGQgYmUgbW92ZWQgdG9vPyBJdCBsb29rcyBhIGJpdCBvdXQgb2YgcGxhY2UKPiBhZnRl
ciB0aGUgdmFsaWRhdGlvbiBnZXRzIG1vdmVkLgoKVGhpcyBpcyBpbnRlbnRpb25hbCAoc2VlIHBh
dGNoIDQpLiBJbiBhIHdheSB0aGlzIGlzIHdoZXJlIHRoZSBkZWNpc2lvbgppcyBtYWRlIHRvIHVz
ZSB0aGUgb3ByZWdpb24gVkJULiBUaGUgb3ByZWdpb24gY29kZSBqdXN0IHZhbGlkYXRlcyBpdCwK
YnV0IGRvZXNuJ3QgYWN0dWFsbHkgKnVzZSogaXQuCgpCUiwKSmFuaS4KCgoKPgo+PiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfb3ByZWdpb24uYyBiL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX29wcmVnaW9uLmMKPj4gaW5kZXggNWI5ZmM3OTBkMzAwLi45Zjk5MmU3
YzYxODUgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX29wcmVnaW9u
LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfb3ByZWdpb24uYwo+PiBAQCAt
OTg2LDggKzk4NiwxMyBAQCBpbnQgaW50ZWxfb3ByZWdpb25fc2V0dXAoc3RydWN0IGRybV9kZXZp
Y2UgKmRldikKPj4gIAlpZiAobWJveGVzICYgTUJPWF9BU0xFX0VYVCkKPj4gIAkJRFJNX0RFQlVH
X0RSSVZFUigiQVNMRSBleHRlbnNpb24gc3VwcG9ydGVkXG4iKTsKPj4gIAo+PiAtCWlmICghZG1p
X2NoZWNrX3N5c3RlbShpbnRlbF9ub19vcHJlZ2lvbl92YnQpKQo+PiAtCQlvcHJlZ2lvbi0+dmJ0
ID0gYmFzZSArIE9QUkVHSU9OX1ZCVF9PRkZTRVQ7Cj4+ICsJaWYgKCFkbWlfY2hlY2tfc3lzdGVt
KGludGVsX25vX29wcmVnaW9uX3ZidCkpIHsKPj4gKwkJdm9pZCAqdmJ0ID0gYmFzZSArIE9QUkVH
SU9OX1ZCVF9PRkZTRVQ7Cj4+ICsJCXUzMiB2YnRfc2l6ZSA9IE9QUkVHSU9OX1NJWkUgLSBPUFJF
R0lPTl9WQlRfT0ZGU0VUOwo+PiArCj4+ICsJCWlmIChpbnRlbF9iaW9zX2lzX3ZhbGlkX3ZidCh2
YnQsIHZidF9zaXplKSkKPj4gKwkJCW9wcmVnaW9uLT52YnQgPSB2YnQ7Cj4+ICsJfQo+PiAgCj4+
ICAJcmV0dXJuIDA7Cj4+ICAKPj4gLS0gCj4+IDIuMS40Cj4+IAo+PiBfX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBJbnRlbC1nZnggbWFpbGluZyBsaXN0
Cj4+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cDovL2xpc3RzLmZyZWVk
ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkphbmkgTmlrdWxhLCBJ
bnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm
eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls
bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=