From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvkSg-0007hs-Ph for qemu-devel@nongnu.org; Mon, 09 Nov 2015 06:18:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvkSe-0006CM-4n for qemu-devel@nongnu.org; Mon, 09 Nov 2015 06:18:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43006) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvkSd-0006CI-Vk for qemu-devel@nongnu.org; Mon, 09 Nov 2015 06:18:08 -0500 From: Juan Quintela In-Reply-To: <1446747083-18205-43-git-send-email-dgilbert@redhat.com> (David Alan Gilbert's message of "Thu, 5 Nov 2015 18:11:09 +0000") References: <1446747083-18205-1-git-send-email-dgilbert@redhat.com> <1446747083-18205-43-git-send-email-dgilbert@redhat.com> Date: Mon, 09 Nov 2015 12:18:04 +0100 Message-ID: <87oaf3bevn.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v9 42/56] Page request: Consume pages off the post-copy queue Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, liang.z.li@intel.com, qemu-devel@nongnu.org, luis@cs.umu.se, bharata@linux.vnet.ibm.com, amit.shah@redhat.com, pbonzini@redhat.com, david@gibson.dropbear.id.au "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > When transmitting RAM pages, consume pages that have been queued by > MIG_RPCOMM_REQPAGE commands and send them ahead of normal page scanning. > > Note: > a) After a queued page the linear walk carries on from after the > unqueued page; there is a reasonable chance that the destination > was about to ask for other closeby pages anyway. > > b) We have to be careful of any assumptions that the page walking > code makes, in particular it does some short cuts on its first linear > walk that break as soon as we do a queued page. > > c) We have to be careful to not break up host-page size chunks, since > this makes it harder to place the pages on the destination. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela