From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: fix kernel-doc warnings in i915_gem.c Date: Fri, 18 Sep 2015 14:26:26 +0300 Message-ID: <87oah0rmsd.fsf@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , David Airlie Cc: Geliang Tang , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAxNSBTZXAgMjAxNSwgR2VsaWFuZyBUYW5nIDxnZWxpYW5ndGFuZ0AxNjMuY29tPiB3 cm90ZToKPiBGaXggdGhlIGZvbGxvd2luZyAnbWFrZSBodG1sZG9jcycgd2FybmluZ3M6Cj4KPiAg IC4vL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmM6MTcyOTogd2FybmluZzogTm8gZGVz Y3JpcHRpb24gZm91bmQgZm9yIHBhcmFtZXRlciAndm1hJwo+ICAgLi8vZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW0uYzoxNzI5OiB3YXJuaW5nOiBObyBkZXNjcmlwdGlvbiBmb3VuZCBmb3Ig cGFyYW1ldGVyICd2bWYnCj4KPiAgIC4vL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmM6 NDk2Mjogd2FybmluZzogTm8gZGVzY3JpcHRpb24gZm91bmQgZm9yIHBhcmFtZXRlciAnb2xkJwo+ ICAgLi8vZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYzo0OTYyOiB3YXJuaW5nOiBObyBk ZXNjcmlwdGlvbiBmb3VuZCBmb3IgcGFyYW1ldGVyICduZXcnCj4gICAuLy9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbS5jOjQ5NjI6IHdhcm5pbmc6IE5vIGRlc2NyaXB0aW9uIGZvdW5kIGZv ciBwYXJhbWV0ZXIgJ2Zyb250YnVmZmVyX2JpdHMnCj4KPiBTaWduZWQtb2ZmLWJ5OiBHZWxpYW5n IFRhbmcgPGdlbGlhbmd0YW5nQDE2My5jb20+CgpQdXNoZWQgdG8gZHJtLWludGVsLW5leHQtcXVl dWVkLCB0aGFua3MgZm9yIHRoZSBwYXRjaC4KCkJSLApKYW5pLgoKCj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCAxMCArKysrKy0tLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCA1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt LmMKPiBpbmRleCA0ZDYzMWE5Li5hOTZmOTdjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5j Cj4gQEAgLTE3MTEsOCArMTcxMSw4IEBAIGk5MTVfZ2VtX21tYXBfaW9jdGwoc3RydWN0IGRybV9k ZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCj4gIC8qKgo+ICAgKiBpOTE1X2dlbV9mYXVsdCAt IGZhdWx0IGEgcGFnZSBpbnRvIHRoZSBHVFQKPiAtICogdm1hOiBWTUEgaW4gcXVlc3Rpb24KPiAt ICogdm1mOiBmYXVsdCBpbmZvCj4gKyAqIEB2bWE6IFZNQSBpbiBxdWVzdGlvbgo+ICsgKiBAdm1m OiBmYXVsdCBpbmZvCj4gICAqCj4gICAqIFRoZSBmYXVsdCBoYW5kbGVyIGlzIHNldCB1cCBieSBk cm1fZ2VtX21tYXAoKSB3aGVuIGEgb2JqZWN0IGlzIEdUVCBtYXBwZWQKPiAgICogZnJvbSB1c2Vy c3BhY2UuICBUaGUgZmF1bHQgaGFuZGxlciB0YWtlcyBjYXJlIG9mIGJpbmRpbmcgdGhlIG9iamVj dCB0bwo+IEBAIC00OTQ5LDkgKzQ5NDksOSBAQCBpbnQgaTkxNV9nZW1fb3BlbihzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUpCj4gIAo+ICAvKioKPiAgICogaTkx NV9nZW1fdHJhY2tfZmIgLSB1cGRhdGUgZnJvbnRidWZmZXIgdHJhY2tpbmcKPiAtICogb2xkOiBj dXJyZW50IEdFTSBidWZmZXIgZm9yIHRoZSBmcm9udGJ1ZmZlciBzbG90cwo+IC0gKiBuZXc6IG5l dyBHRU0gYnVmZmVyIGZvciB0aGUgZnJvbnRidWZmZXIgc2xvdHMKPiAtICogZnJvbnRidWZmZXJf Yml0czogYml0bWFzayBvZiBmcm9udGJ1ZmZlciBzbG90cwo+ICsgKiBAb2xkOiBjdXJyZW50IEdF TSBidWZmZXIgZm9yIHRoZSBmcm9udGJ1ZmZlciBzbG90cwo+ICsgKiBAbmV3OiBuZXcgR0VNIGJ1 ZmZlciBmb3IgdGhlIGZyb250YnVmZmVyIHNsb3RzCj4gKyAqIEBmcm9udGJ1ZmZlcl9iaXRzOiBi aXRtYXNrIG9mIGZyb250YnVmZmVyIHNsb3RzCj4gICAqCj4gICAqIFRoaXMgdXBkYXRlcyB0aGUg ZnJvbnRidWZmZXIgdHJhY2tpbmcgYml0cyBAZnJvbnRidWZmZXJfYml0cyBieSBjbGVhcmluZyB0 aGVtCj4gICAqIGZyb20gQG9sZCBhbmQgc2V0dGluZyB0aGVtIGluIEBuZXcuIEJvdGggQG9sZCBh bmQgQG5ldyBjYW4gYmUgTlVMTC4KPiAtLSAKPiAxLjkuMQo+Cj4KCi0tIApKYW5pIE5pa3VsYSwg SW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753496AbbIRLXO (ORCPT ); Fri, 18 Sep 2015 07:23:14 -0400 Received: from mga09.intel.com ([134.134.136.24]:50319 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751714AbbIRLXN (ORCPT ); Fri, 18 Sep 2015 07:23:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,552,1437462000"; d="scan'208";a="808018171" From: Jani Nikula To: Geliang Tang , Daniel Vetter , David Airlie Cc: Geliang Tang , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/i915: fix kernel-doc warnings in i915_gem.c In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: User-Agent: Notmuch/0.20.2+58~g39779b9 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Fri, 18 Sep 2015 14:26:26 +0300 Message-ID: <87oah0rmsd.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Sep 2015, Geliang Tang wrote: > Fix the following 'make htmldocs' warnings: > > .//drivers/gpu/drm/i915/i915_gem.c:1729: warning: No description found for parameter 'vma' > .//drivers/gpu/drm/i915/i915_gem.c:1729: warning: No description found for parameter 'vmf' > > .//drivers/gpu/drm/i915/i915_gem.c:4962: warning: No description found for parameter 'old' > .//drivers/gpu/drm/i915/i915_gem.c:4962: warning: No description found for parameter 'new' > .//drivers/gpu/drm/i915/i915_gem.c:4962: warning: No description found for parameter 'frontbuffer_bits' > > Signed-off-by: Geliang Tang Pushed to drm-intel-next-queued, thanks for the patch. BR, Jani. > --- > drivers/gpu/drm/i915/i915_gem.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index 4d631a9..a96f97c 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -1711,8 +1711,8 @@ i915_gem_mmap_ioctl(struct drm_device *dev, void *data, > > /** > * i915_gem_fault - fault a page into the GTT > - * vma: VMA in question > - * vmf: fault info > + * @vma: VMA in question > + * @vmf: fault info > * > * The fault handler is set up by drm_gem_mmap() when a object is GTT mapped > * from userspace. The fault handler takes care of binding the object to > @@ -4949,9 +4949,9 @@ int i915_gem_open(struct drm_device *dev, struct drm_file *file) > > /** > * i915_gem_track_fb - update frontbuffer tracking > - * old: current GEM buffer for the frontbuffer slots > - * new: new GEM buffer for the frontbuffer slots > - * frontbuffer_bits: bitmask of frontbuffer slots > + * @old: current GEM buffer for the frontbuffer slots > + * @new: new GEM buffer for the frontbuffer slots > + * @frontbuffer_bits: bitmask of frontbuffer slots > * > * This updates the frontbuffer tracking bits @frontbuffer_bits by clearing them > * from @old and setting them in @new. Both @old and @new can be NULL. > -- > 1.9.1 > > -- Jani Nikula, Intel Open Source Technology Center