From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZZuhh-0001Ed-HP for ath10k@lists.infradead.org; Thu, 10 Sep 2015 05:47:26 +0000 From: Kalle Valo Subject: Re: [PATCH 3/3] ath10k: implement mesh support References: <1440673024-13696-1-git-send-email-me@bobcopeland.com> <1440673024-13696-4-git-send-email-me@bobcopeland.com> <87oahc9g9h.fsf@kamboji.qca.qualcomm.com> <87fv2o9cvl.fsf@kamboji.qca.qualcomm.com> <20150909164945.GA4062@localhost> Date: Thu, 10 Sep 2015 08:46:54 +0300 In-Reply-To: <20150909164945.GA4062@localhost> (Bob Copeland's message of "Wed, 9 Sep 2015 12:49:45 -0400") Message-ID: <87oaha4yi9.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Bob Copeland Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Bob Copeland writes: > On Wed, Sep 09, 2015 at 12:10:38PM +0300, Kalle Valo wrote: >> > I did a quick smoke test and saw the splat below. It's this warning from >> > cfg80211: >> > >> > /* >> > * Don't advertise an unsupported type >> > * in a combination. >> > */ >> > if (WARN_ON((wiphy->interface_modes & types) != types)) >> > return -EINVAL; > > OK, this happens when mesh is configured out (we mask off the mesh > interface_modes internally but not the types). Sent an updated version > with appropriate ifdefs added. Indeed, when I enabled CONFIG_MAC80211_MESH I didn't see the WARN_ON() anymore. (I haven't tested your latest version yet, will do it soon) -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:7727 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905AbbIJFrV (ORCPT ); Thu, 10 Sep 2015 01:47:21 -0400 From: Kalle Valo To: Bob Copeland CC: , Subject: Re: [PATCH 3/3] ath10k: implement mesh support References: <1440673024-13696-1-git-send-email-me@bobcopeland.com> <1440673024-13696-4-git-send-email-me@bobcopeland.com> <87oahc9g9h.fsf@kamboji.qca.qualcomm.com> <87fv2o9cvl.fsf@kamboji.qca.qualcomm.com> <20150909164945.GA4062@localhost> Date: Thu, 10 Sep 2015 08:46:54 +0300 In-Reply-To: <20150909164945.GA4062@localhost> (Bob Copeland's message of "Wed, 9 Sep 2015 12:49:45 -0400") Message-ID: <87oaha4yi9.fsf@kamboji.qca.qualcomm.com> (sfid-20150910_074724_704476_995CA5A4) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Bob Copeland writes: > On Wed, Sep 09, 2015 at 12:10:38PM +0300, Kalle Valo wrote: >> > I did a quick smoke test and saw the splat below. It's this warning from >> > cfg80211: >> > >> > /* >> > * Don't advertise an unsupported type >> > * in a combination. >> > */ >> > if (WARN_ON((wiphy->interface_modes & types) != types)) >> > return -EINVAL; > > OK, this happens when mesh is configured out (we mask off the mesh > interface_modes internally but not the types). Sent an updated version > with appropriate ifdefs added. Indeed, when I enabled CONFIG_MAC80211_MESH I didn't see the WARN_ON() anymore. (I haven't tested your latest version yet, will do it soon) -- Kalle Valo