From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: fix VBT parsing for SDVO child device mapping Date: Wed, 19 Aug 2015 09:54:05 +0300 Message-ID: <87oai3db02.fsf@intel.com> References: <1439897335-7804-1-git-send-email-jani.nikula@intel.com> <20150818135717.GK5176@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id C036D6EB5C for ; Tue, 18 Aug 2015 23:51:06 -0700 (PDT) In-Reply-To: <20150818135717.GK5176@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAxOCBBdWcgMjAxNSwgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gVHVlLCBBdWcgMTgsIDIwMTUgYXQgMDI6Mjg6NTVQTSAr MDMwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4+IGNvbW1pdCA3NTA2N2RkZWNmMjEyNzE2MzFiYzAx OGQyZmIyM2RkZDA5YjY2YWFlCj4+IEF1dGhvcjogQW50dGkgS29za2lwYWEgPGFudHRpLmtvc2tp cGFhQGxpbnV4LmludGVsLmNvbT4KPj4gRGF0ZTogICBGcmkgSnVsIDEwIDE0OjEwOjU1IDIwMTUg KzAzMDAKPj4gCj4+ICAgICBkcm0vaTkxNTogUGVyLURESSBJX2Jvb3N0IG92ZXJyaWRlCj4+IAo+ PiBpbmNyZWFzZWQgc2l6ZSBvZiB1bmlvbiBjaGlsZF9kZXZpY2VfY29uZmlnIHdpdGhvdXQgdGFr aW5nIGludG8gYWNjb3VudAo+PiB0aGUgc2l6ZSBjaGVjayBpbiBwYXJzZV9zZHZvX2RldmljZV9t YXBwaW5nKCkuIFN3aXRjaCB0aGUgZnVuY3Rpb24gb3Zlcgo+PiB0byB1c2luZyB0aGUgbGVnYWN5 IHN0cnVjdCBvbmx5Lgo+PiAKPj4gRml4ZXM6IDc1MDY3ZGRlY2YyMSAoImRybS9pOTE1OiBQZXIt RERJIElfYm9vc3Qgb3ZlcnJpZGUiKQo+PiBDYzogQW50dGkgS29za2lwYWEgPGFudHRpLmtvc2tp cGFhQGxpbnV4LmludGVsLmNvbT4KPj4gQ2M6IERhdmlkIFdlaW5laGFsbCA8ZGF2aWQud2VpbmVo YWxsQGxpbnV4LmludGVsLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmku bmlrdWxhQGludGVsLmNvbT4KPgo+IFJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+Cj4gQWxzbyBnYXZlIGl0IGEgc3BpbiBvbiBteSA5 NDZneiBzbzoKPiBUZXN0ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+CgpQdXNoZWQgdG8gZHJtLWludGVsLW5leHQtZml4ZXMsIHRoYW5rcyBmb3Ig dGhlIHJldmlldyBhbmQgdGVzdGluZy4KCkJSLApKYW5pLgoKCj4KPj4gLS0tCj4+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMgfCA1MCArKysrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0tLS0tLS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCAyNSBk ZWxldGlvbnMoLSkKPj4gCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9iaW9zLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPj4gaW5kZXggOGU0 NjE0OWJhZmRkLi4xYjdlMWE1OTFhMzcgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Jpb3MuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9z LmMKPj4gQEAgLTQwMSw3ICs0MDEsNyBAQCBwYXJzZV9zZHZvX2RldmljZV9tYXBwaW5nKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gIHsKPj4gIAlzdHJ1Y3Qgc2R2b19kZXZp Y2VfbWFwcGluZyAqcF9tYXBwaW5nOwo+PiAgCWNvbnN0IHN0cnVjdCBiZGJfZ2VuZXJhbF9kZWZp bml0aW9ucyAqcF9kZWZzOwo+PiAtCWNvbnN0IHVuaW9uIGNoaWxkX2RldmljZV9jb25maWcgKnBf Y2hpbGQ7Cj4+ICsJY29uc3Qgc3RydWN0IG9sZF9jaGlsZF9kZXZfY29uZmlnICpjaGlsZDsgLyog bGVnYWN5ICovCj4+ICAJaW50IGksIGNoaWxkX2RldmljZV9udW0sIGNvdW50Owo+PiAgCXUxNgli bG9ja19zaXplOwo+PiAgCj4+IEBAIC00MTAsMTQgKzQxMCwxNCBAQCBwYXJzZV9zZHZvX2Rldmlj ZV9tYXBwaW5nKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gIAkJRFJNX0RF QlVHX0tNUygiTm8gZ2VuZXJhbCBkZWZpbml0aW9uIGJsb2NrIGlzIGZvdW5kLCB1bmFibGUgdG8g Y29uc3RydWN0IHNkdm8gbWFwcGluZy5cbiIpOwo+PiAgCQlyZXR1cm47Cj4+ICAJfQo+PiAtCS8q IGp1ZGdlIHdoZXRoZXIgdGhlIHNpemUgb2YgY2hpbGQgZGV2aWNlIG1lZXRzIHRoZSByZXF1aXJl bWVudHMuCj4+IC0JICogSWYgdGhlIGNoaWxkIGRldmljZSBzaXplIG9idGFpbmVkIGZyb20gZ2Vu ZXJhbCBkZWZpbml0aW9uIGJsb2NrCj4+IC0JICogaXMgZGlmZmVyZW50IHdpdGggc2l6ZW9mKHN0 cnVjdCBjaGlsZF9kZXZpY2VfY29uZmlnKSwgc2tpcCB0aGUKPj4gLQkgKiBwYXJzaW5nIG9mIHNk dm8gZGV2aWNlIGluZm8KPj4gKwo+PiArCS8qCj4+ICsJICogT25seSBwYXJzZSBTRFZPIG1hcHBp bmdzIHdoZW4gdGhlIGdlbmVyYWwgZGVmaW5pdGlvbnMgYmxvY2sgY2hpbGQKPj4gKwkgKiBkZXZp Y2Ugc2l6ZSBtYXRjaGVzIHRoYXQgb2YgdGhlICpsZWdhY3kqIGNoaWxkIGRldmljZSBjb25maWcK Pj4gKwkgKiBzdHJ1Y3QuIFRodXMsIFNEVk8gbWFwcGluZyB3aWxsIGJlIHNraXBwZWQgZm9yIG5l d2VyIFZCVC4KPj4gIAkgKi8KPj4gLQlpZiAocF9kZWZzLT5jaGlsZF9kZXZfc2l6ZSAhPSBzaXpl b2YoKnBfY2hpbGQpKSB7Cj4+IC0JCS8qIGRpZmZlcmVudCBjaGlsZCBkZXYgc2l6ZSAuIElnbm9y ZSBpdCAqLwo+PiAtCQlEUk1fREVCVUdfS01TKCJkaWZmZXJlbnQgY2hpbGQgc2l6ZSBpcyBmb3Vu ZC4gSW52YWxpZC5cbiIpOwo+PiArCWlmIChwX2RlZnMtPmNoaWxkX2Rldl9zaXplICE9IHNpemVv ZigqY2hpbGQpKSB7Cj4+ICsJCURSTV9ERUJVR19LTVMoIlVuc3VwcG9ydGVkIGNoaWxkIGRldmlj ZSBzaXplIGZvciBTRFZPIG1hcHBpbmcuXG4iKTsKPj4gIAkJcmV0dXJuOwo+PiAgCX0KPj4gIAkv KiBnZXQgdGhlIGJsb2NrIHNpemUgb2YgZ2VuZXJhbCBkZWZpbml0aW9ucyAqLwo+PiBAQCAtNDI3 LDM3ICs0MjcsMzcgQEAgcGFyc2Vfc2R2b19kZXZpY2VfbWFwcGluZyhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsCj4+ICAJCXBfZGVmcy0+Y2hpbGRfZGV2X3NpemU7Cj4+ICAJY291 bnQgPSAwOwo+PiAgCWZvciAoaSA9IDA7IGkgPCBjaGlsZF9kZXZpY2VfbnVtOyBpKyspIHsKPj4g LQkJcF9jaGlsZCA9IGNoaWxkX2RldmljZV9wdHIocF9kZWZzLCBpKTsKPj4gLQkJaWYgKCFwX2No aWxkLT5vbGQuZGV2aWNlX3R5cGUpIHsKPj4gKwkJY2hpbGQgPSAmY2hpbGRfZGV2aWNlX3B0cihw X2RlZnMsIGkpLT5vbGQ7Cj4+ICsJCWlmICghY2hpbGQtPmRldmljZV90eXBlKSB7Cj4+ICAJCQkv KiBza2lwIHRoZSBkZXZpY2UgYmxvY2sgaWYgZGV2aWNlIHR5cGUgaXMgaW52YWxpZCAqLwo+PiAg CQkJY29udGludWU7Cj4+ICAJCX0KPj4gLQkJaWYgKHBfY2hpbGQtPm9sZC5zbGF2ZV9hZGRyICE9 IFNMQVZFX0FERFIxICYmCj4+IC0JCQlwX2NoaWxkLT5vbGQuc2xhdmVfYWRkciAhPSBTTEFWRV9B RERSMikgewo+PiArCQlpZiAoY2hpbGQtPnNsYXZlX2FkZHIgIT0gU0xBVkVfQUREUjEgJiYKPj4g KwkJICAgIGNoaWxkLT5zbGF2ZV9hZGRyICE9IFNMQVZFX0FERFIyKSB7Cj4+ICAJCQkvKgo+PiAg CQkJICogSWYgdGhlIHNsYXZlIGFkZHJlc3MgaXMgbmVpdGhlciAweDcwIG5vciAweDcyLAo+PiAg CQkJICogaXQgaXMgbm90IGEgU0RWTyBkZXZpY2UuIFNraXAgaXQuCj4+ICAJCQkgKi8KPj4gIAkJ CWNvbnRpbnVlOwo+PiAgCQl9Cj4+IC0JCWlmIChwX2NoaWxkLT5vbGQuZHZvX3BvcnQgIT0gREVW SUNFX1BPUlRfRFZPQiAmJgo+PiAtCQkJcF9jaGlsZC0+b2xkLmR2b19wb3J0ICE9IERFVklDRV9Q T1JUX0RWT0MpIHsKPj4gKwkJaWYgKGNoaWxkLT5kdm9fcG9ydCAhPSBERVZJQ0VfUE9SVF9EVk9C ICYmCj4+ICsJCSAgICBjaGlsZC0+ZHZvX3BvcnQgIT0gREVWSUNFX1BPUlRfRFZPQykgewo+PiAg CQkJLyogc2tpcCB0aGUgaW5jb3JyZWN0IFNEVk8gcG9ydCAqLwo+PiAgCQkJRFJNX0RFQlVHX0tN UygiSW5jb3JyZWN0IFNEVk8gcG9ydC4gU2tpcCBpdFxuIik7Cj4+ICAJCQljb250aW51ZTsKPj4g IAkJfQo+PiAgCQlEUk1fREVCVUdfS01TKCJ0aGUgU0RWTyBkZXZpY2Ugd2l0aCBzbGF2ZSBhZGRy ICUyeCBpcyBmb3VuZCBvbiIKPj4gLQkJCQkiICVzIHBvcnRcbiIsCj4+IC0JCQkJcF9jaGlsZC0+ b2xkLnNsYXZlX2FkZHIsCj4+IC0JCQkJKHBfY2hpbGQtPm9sZC5kdm9fcG9ydCA9PSBERVZJQ0Vf UE9SVF9EVk9CKSA/Cj4+IC0JCQkJCSJTRFZPQiIgOiAiU0RWT0MiKTsKPj4gLQkJcF9tYXBwaW5n ID0gJihkZXZfcHJpdi0+c2R2b19tYXBwaW5nc1twX2NoaWxkLT5vbGQuZHZvX3BvcnQgLSAxXSk7 Cj4+ICsJCQkgICAgICAiICVzIHBvcnRcbiIsCj4+ICsJCQkgICAgICBjaGlsZC0+c2xhdmVfYWRk ciwKPj4gKwkJCSAgICAgIChjaGlsZC0+ZHZvX3BvcnQgPT0gREVWSUNFX1BPUlRfRFZPQikgPwo+ PiArCQkJICAgICAgIlNEVk9CIiA6ICJTRFZPQyIpOwo+PiArCQlwX21hcHBpbmcgPSAmKGRldl9w cml2LT5zZHZvX21hcHBpbmdzW2NoaWxkLT5kdm9fcG9ydCAtIDFdKTsKPj4gIAkJaWYgKCFwX21h cHBpbmctPmluaXRpYWxpemVkKSB7Cj4+IC0JCQlwX21hcHBpbmctPmR2b19wb3J0ID0gcF9jaGls ZC0+b2xkLmR2b19wb3J0Owo+PiAtCQkJcF9tYXBwaW5nLT5zbGF2ZV9hZGRyID0gcF9jaGlsZC0+ b2xkLnNsYXZlX2FkZHI7Cj4+IC0JCQlwX21hcHBpbmctPmR2b193aXJpbmcgPSBwX2NoaWxkLT5v bGQuZHZvX3dpcmluZzsKPj4gLQkJCXBfbWFwcGluZy0+ZGRjX3BpbiA9IHBfY2hpbGQtPm9sZC5k ZGNfcGluOwo+PiAtCQkJcF9tYXBwaW5nLT5pMmNfcGluID0gcF9jaGlsZC0+b2xkLmkyY19waW47 Cj4+ICsJCQlwX21hcHBpbmctPmR2b19wb3J0ID0gY2hpbGQtPmR2b19wb3J0Owo+PiArCQkJcF9t YXBwaW5nLT5zbGF2ZV9hZGRyID0gY2hpbGQtPnNsYXZlX2FkZHI7Cj4+ICsJCQlwX21hcHBpbmct PmR2b193aXJpbmcgPSBjaGlsZC0+ZHZvX3dpcmluZzsKPj4gKwkJCXBfbWFwcGluZy0+ZGRjX3Bp biA9IGNoaWxkLT5kZGNfcGluOwo+PiArCQkJcF9tYXBwaW5nLT5pMmNfcGluID0gY2hpbGQtPmky Y19waW47Cj4+ICAJCQlwX21hcHBpbmctPmluaXRpYWxpemVkID0gMTsKPj4gIAkJCURSTV9ERUJV R19LTVMoIlNEVk8gZGV2aWNlOiBkdm89JXgsIGFkZHI9JXgsIHdpcmluZz0lZCwgZGRjX3Bpbj0l ZCwgaTJjX3Bpbj0lZFxuIiwKPj4gIAkJCQkgICAgICBwX21hcHBpbmctPmR2b19wb3J0LAo+PiBA QCAtNDY5LDcgKzQ2OSw3IEBAIHBhcnNlX3Nkdm9fZGV2aWNlX21hcHBpbmcoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiAgCQkJRFJNX0RFQlVHX0tNUygiTWF5YmUgb25lIFNE Vk8gcG9ydCBpcyBzaGFyZWQgYnkgIgo+PiAgCQkJCQkgInR3byBTRFZPIGRldmljZS5cbiIpOwo+ PiAgCQl9Cj4+IC0JCWlmIChwX2NoaWxkLT5vbGQuc2xhdmUyX2FkZHIpIHsKPj4gKwkJaWYgKGNo aWxkLT5zbGF2ZTJfYWRkcikgewo+PiAgCQkJLyogTWF5YmUgdGhpcyBpcyBhIFNEVk8gZGV2aWNl IHdpdGggbXVsdGlwbGUgaW5wdXRzICovCj4+ICAJCQkvKiBBbmQgdGhlIG1hcHBpbmcgaW5mbyBp cyBub3QgYWRkZWQgKi8KPj4gIAkJCURSTV9ERUJVR19LTVMoInRoZXJlIGV4aXN0cyB0aGUgc2xh dmUyX2FkZHIuIE1heWJlIHRoaXMiCj4+IC0tIAo+PiAyLjEuNAo+PiAKPj4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPj4gSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdAo+PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHA6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPgo+IC0tIAo+IFZpbGxl IFN5cmrDpGzDpAo+IEludGVsIE9UQwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJj ZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=