From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [BUG] i915: suspend by closing Laptop lid broken Date: Thu, 07 May 2015 16:50:06 +0300 Message-ID: <87oalw5wfl.fsf@intel.com> References: <55474FD2.7070600@posteo.de> <87a8xk8u20.fsf@intel.com> <554B6A1B.9050201@posteo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <554B6A1B.9050201@posteo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Martin Kepplinger , daniel.vetter@intel.com, airlied@linux.ie Cc: intel-gfx@lists.freedesktop.org, "linux-kernel@vger.kernel.org" , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAwNyBNYXkgMjAxNSwgTWFydGluIEtlcHBsaW5nZXIgPG1hcnRpbmtAcG9zdGVvLmRl PiB3cm90ZToKPiBBbSAyMDE1LTA1LTA0IHVtIDEzOjI0IHNjaHJpZWIgSmFuaSBOaWt1bGE6Cj4+ IE9uIE1vbiwgMDQgTWF5IDIwMTUsIE1hcnRpbiBLZXBwbGluZ2VyIDxtYXJ0aW5rQHBvc3Rlby5k ZT4gd3JvdGU6Cj4+PiBTby4gLXJjMSBicm9rZSBzdXNwZW5kaW5nIGJ5IGNsb3NpbmcgbXkgbGFw dG9wIGxpZCBhbmQgaXQncyBub3QgZml4ZWQgaW4KPj4+IC1yYzIuIEl0IHdvcmtzIGV4YWN0bHkg Km9uZSogZmlyc3QgdGltZSBhbmQgZXZlcnkgc3Vic2VxdWVudCBsaWQtY2xvc2luZwo+Pj4gaXMg aWdub3JlZC4KPj4+Cj4+PiBCaXNjdGVkIGFuZCB0ZXN0ZWQgZmlyc3QgYmFkIGNvbW1pdDoKPj4+ IDE0YWEwMjQ0OTA2NDU0MTIxNzgzNmI5ZjNkMzI5NWUyNDFkNWFlOWMKPj4+Cj4+PiBUaGlzIHB1 bGxzIGluIGk5MTUgY2hhbmdlcyBhcyB3ZWxsIGFzIEFDUEkgY2hhbmdlcy4gSSBkb24ndCBrbm93 IHRoZQo+Pj4gZHJpdmVyIGJ1dCBJJ20gc3VyZSB5b3UgY2FuIGZpbmQgdGhlIG1pc3Rha2UuIEkn bSBoYXBweSB0byB0ZXN0IGNoYW5nZXMuCj4+Pgo+Pj4gVGhlcmUgYXJlIG5vIGxvZyBkaWZmZXJl bmNlcy4KPj4gCj4+IEFueSBjaGFuY2UgeW91IGNvdWxkIGJpc2VjdCBpbnRvIHRoZSBtZXJnZT8g SXQgd291bGQgYmUgaGVscGZ1bC4KPj4gCj4+IEJSLAo+PiBKYW5pLgo+PiAKPj4gCj4KPiBNeSBh dHRlbXB0IHRvIGdvIGludG8gdGhlIG1lcmdlIHdhcyB0b28gbXVjaCBlZmZvcnQgYXMgdGhlIGNo ZWNrb3V0cyBpbgo+IGJldHdlZW4gYnJlYWsgcmFuZG9tIG90aGVyIHN0dWZmLgoKVGhpcyBzaG91 bGQgb2J2aW91c2x5ICpub3QqIGJlIHRoZSBjYXNlLiA6KAoKPiBXZSBzaG91bGQgYmUgYmV0d2Vl biAwOWQ1MTYwMmNmODRhMTI2NDk0NjcxMWRkNGVhMGRkZGJhYzU5OWExIChnb29kKSBhbmQKPiBj MGY0MDQyODQxOTJmMmQ0YTAxNTlhNzE0MzcyYThjODYxMGMxZjZkLiBDb3VsZCB5b3UgaGF2ZSBh IGxvb2sgYW5kCj4gbWF5YmUgeW91IGhhdmUgZ3Vlc3NlcyBmb3IgbWUsIHdoYXQgSSBzaG91bGQg dGVzdD8gSXQncyBub3Qgc29vbyBtdWNoCj4gYW55bW9yZSwgbWF5YmUgeW91IGV2ZW4gaGF2ZSBh IGd1ZXNzIGFib3V0IHRoZSBidWc/CgokIGdpdCBsb2cgLS1vbmVsaW5lIDA5ZDUxNjAyY2YuLmMw ZjQwNDI4NDEgfCBncmVwIGRybS9pOTE1IHwgd2MgLWwKMjg2CgpPb2YsIEkgZXllYmFsbGVkIHRo ZSBsaXN0LCBidXQgZGlkbid0IHNwb3QgYW55IG9idmlvdXMgY2FuZGlkYXRlcy4KCklmIGEgY29t bWl0IGlzIGluY29uY2x1c2l2ZSBvciBib3JrZW4gaW4gb3RoZXIgd2F5cywgeW91IGNvdWxkIHRy eSBnaXQKYmlzZWN0IHNraXAgdG8gdHJ5IGFub3RoZXIgY29tbWl0Li4uCgpCUiwKSmFuaS4KCgot LSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751537AbbEGNsU (ORCPT ); Thu, 7 May 2015 09:48:20 -0400 Received: from mga09.intel.com ([134.134.136.24]:35445 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352AbbEGNsR (ORCPT ); Thu, 7 May 2015 09:48:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,384,1427785200"; d="scan'208";a="722226128" From: Jani Nikula To: Martin Kepplinger , daniel.vetter@intel.com, airlied@linux.ie Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, "linux-kernel\@vger.kernel.org" Subject: Re: [BUG] i915: suspend by closing Laptop lid broken In-Reply-To: <554B6A1B.9050201@posteo.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <55474FD2.7070600@posteo.de> <87a8xk8u20.fsf@intel.com> <554B6A1B.9050201@posteo.de> User-Agent: Notmuch/0.19+112~g77230b0 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Thu, 07 May 2015 16:50:06 +0300 Message-ID: <87oalw5wfl.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 07 May 2015, Martin Kepplinger wrote: > Am 2015-05-04 um 13:24 schrieb Jani Nikula: >> On Mon, 04 May 2015, Martin Kepplinger wrote: >>> So. -rc1 broke suspending by closing my laptop lid and it's not fixed in >>> -rc2. It works exactly *one* first time and every subsequent lid-closing >>> is ignored. >>> >>> Biscted and tested first bad commit: >>> 14aa02449064541217836b9f3d3295e241d5ae9c >>> >>> This pulls in i915 changes as well as ACPI changes. I don't know the >>> driver but I'm sure you can find the mistake. I'm happy to test changes. >>> >>> There are no log differences. >> >> Any chance you could bisect into the merge? It would be helpful. >> >> BR, >> Jani. >> >> > > My attempt to go into the merge was too much effort as the checkouts in > between break random other stuff. This should obviously *not* be the case. :( > We should be between 09d51602cf84a1264946711dd4ea0dddbac599a1 (good) and > c0f404284192f2d4a0159a714372a8c8610c1f6d. Could you have a look and > maybe you have guesses for me, what I should test? It's not sooo much > anymore, maybe you even have a guess about the bug? $ git log --oneline 09d51602cf..c0f4042841 | grep drm/i915 | wc -l 286 Oof, I eyeballed the list, but didn't spot any obvious candidates. If a commit is inconclusive or borken in other ways, you could try git bisect skip to try another commit... BR, Jani. -- Jani Nikula, Intel Open Source Technology Center