From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYYzd-0001vY-0f for qemu-devel@nongnu.org; Thu, 19 Mar 2015 07:52:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYYzc-0003KD-7y for qemu-devel@nongnu.org; Thu, 19 Mar 2015 07:52:04 -0400 From: Markus Armbruster References: <1426577774-21605-1-git-send-email-armbru@redhat.com> <20150319112954.GB3845@noname.redhat.com> Date: Thu, 19 Mar 2015 12:51:53 +0100 In-Reply-To: <20150319112954.GB3845@noname.redhat.com> (Kevin Wolf's message of "Thu, 19 Mar 2015 12:29:54 +0100") Message-ID: <87oanpp5ly.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] block: Fix blockdev-backup not to use funky error class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-block@nongnu.org, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Kevin Wolf writes: > Am 17.03.2015 um 08:36 hat Markus Armbruster geschrieben: >> Error classes are a leftover from the days of "rich" error objects. >> New code should always use ERROR_CLASS_GENERIC_ERROR. Commit >> b7b9d39..7c6a4ab added uses of ERROR_CLASS_DEVICE_NOT_FOUND. Replace >> them. >> >> Signed-off-by: Markus Armbruster > > Thanks, applied to the block branch. > > Eric, please speak up if libvirt needs the error code for any of these. I grepped through the libvirt source code (should've mentioned that), but review from an expert is of course always welcome!