Re: [PATCH 2/2] ARM: pxa: add lubbock board support

[Robert Jarzmik <robert.jarzmik@free.fr>]

Sascha Hauer <s.hauer@pengutronix.de> writes:

> On Mon, Jan 26, 2015 at 10:33:47PM +0100, Robert Jarzmik wrote:
>> +
>> +static int lubbock_mem_init(void)
>> +{
>> +	arm_add_mem_device("ram0", 0xa0000000, SZ_64M);
>> +	arm_add_mem_device("sram0", 0x0a000000, SZ_1M);
>
> When doing this you'll end up with the SRAM being in ATAGS which is
> probably not what you want. Use add_mem_device() instead.
Right, for v2.

> No hardcoded MAC addresses please. barebox generates a random MAC
> address for you if your board is unable to provide a real one.

I'll remove that from the upstreamed patch. I'll keep it for me for my ISP
router to give me consistently the same IP address through DHCP.

>> +dhcp -H lubbock
>
> dhcp during init time? This unnecessarily delays the boot process when
> booting from flash.
>
> This environment looks very specific to your usecase. Can't you just use
> the generic defenv-2 template?
I'll try for v2, yes.
Speaking of which, this implies one redundant information :
 - the env/init/mtdpart-nor to define partitions (including bareboxenv)
 - the code to add env0:
   devfs_add_partition("nor0", SZ_2M, SZ_256K, DEVFS_PARTITION_FIXED, "env0")

This means that if the partition scheme changes, barebox binary has to be
recompiled and reflashed. Isn't there a better way ? (that was what my
mtd_env_override tried to do btw).

Cheers.

-- 
Robert

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox