All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	Juan Quintela <quintela@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-file: Add copyright header to qemu-file.c
Date: Thu, 02 Oct 2014 08:26:10 +0200	[thread overview]
Message-ID: <87oatvrnr1.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <20141001175717.GW2606@work-vm> (David Alan Gilbert's message of "Wed, 1 Oct 2014 18:57:17 +0100")

"Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:

> * Eduardo Habkost (ehabkost@redhat.com) wrote:
>> The person who created qemu-file.c (me, on commit
>> 093c455a8c6d8f715eabd8c8d346f08f17d686ec) didn't add a copyright/license
>> header to the file, even though the whole code was copied from savevm.c
>> (which had a copyright/license header).
>> 
>> To correct this, copy the copyright information and license from
>> savevm.c, that's where the original code came from.
>> 
>> Luckily, very few changes were made on qemu-file.c after it was created.
>> All the authors who touched the code are being CCed, so they can confirm
>> if they are OK with the copyright/license information being added.
>
> Since it's come from vl.c that seems to make sense.
> It should probably go to the stable branch as well, since reading the ~/LICENSE
> file would make you think it's GPLd.
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Since we released it that way, licensees could in good faith assume they
got it under GPL.

My contribution was just a one-liner bug fix.  Regardless:

Reviewed-by: Markus Armbruster <armbru@redhat.com>

  reply	other threads:[~2014-10-02  6:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01 17:47 [Qemu-devel] [PATCH] qemu-file: Add copyright header to qemu-file.c Eduardo Habkost
2014-10-01 17:57 ` Dr. David Alan Gilbert
2014-10-02  6:26   ` Markus Armbruster [this message]
2014-10-02  4:18 ` Alexey Kardashevskiy
2014-10-14  8:14 ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oatvrnr1.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.