From: Juan Quintela <quintela@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: "qemu list" <qemu-devel@nongnu.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Alexander Graf" <agraf@suse.de>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v5 00/18] migration: add static analysis tool to check vmstate compat
Date: Tue, 24 Jun 2014 15:17:12 +0200 [thread overview]
Message-ID: <87oaximopz.fsf@troll.troll> (raw)
In-Reply-To: <cover.1403269079.git.amit.shah@redhat.com> (Amit Shah's message of "Fri, 20 Jun 2014 18:56:07 +0530")
Amit Shah <amit.shah@redhat.com> wrote:
> Hello,
>
> v5:
> - Add section / description name checking for matching names for
> changed fields. This has the benefit of also getting rid of the
> for loop in the lookup. However, for each section, like piix4_pm,
> all the changes have to be in one group, as against them being in
> different ones. That's still better than earlier where sections
> were not checked. If my Python gets better, I might come up with a
> way to improve on this as well. (Juan Quintela)
> - Add more comments to the Python script
> - Update help text to be more verbose - for qemu and for the script.
> - Simplify the check_fields() function - lesser indentations
Applied.
Later, Juan.
prev parent reply other threads:[~2014-06-24 13:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 13:26 [Qemu-devel] [PATCH v5 00/18] migration: add static analysis tool to check vmstate compat Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 01/18] migration: dump vmstate info as a json file for static analysis Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 02/18] vmstate-static-checker: script to validate vmstate changes Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 03/18] tests: vmstate static checker: add dump1 and dump2 files Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 04/18] tests: vmstate static checker: incompat machine types Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 05/18] tests: vmstate static checker: add version error in main section Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 06/18] tests: vmstate static checker: version mismatch inside a Description Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 07/18] tests: vmstate static checker: minimum_version_id check Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 08/18] tests: vmstate static checker: remove a section Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 09/18] tests: vmstate static checker: remove a field Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 10/18] tests: vmstate static checker: remove last field in a struct Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 11/18] tests: vmstate static checker: change description name Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 12/18] tests: vmstate static checker: remove Fields Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 13/18] tests: vmstate static checker: remove Description Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 14/18] tests: vmstate static checker: remove Description inside Fields Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 15/18] tests: vmstate static checker: remove a subsection Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 16/18] tests: vmstate static checker: remove Subsections Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 17/18] tests: vmstate static checker: add substructure for usb-kbd for hid section Amit Shah
2014-06-20 13:26 ` [Qemu-devel] [PATCH v5 18/18] tests: vmstate static checker: add size mismatch inside substructure Amit Shah
2014-06-24 13:17 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oaximopz.fsf@troll.troll \
--to=quintela@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.