From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58446)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Ws9NX-0008KJ-Lf
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 07:29:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Ws9NQ-0000fx-1F
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 07:29:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47334)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Ws9NP-0000fr-Ol
	for qemu-devel@nongnu.org; Wed, 04 Jun 2014 07:29:03 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <CAAUTuqCfQdTm5SUm6+P9NOoL7_o1=oZ1ys-ciuf29HG4_3jmXw@mail.gmail.com>
	(Sanidhya Kashyap's message of "Wed, 4 Jun 2014 15:46:16 +0530")
References: <1401863911-5947-1-git-send-email-sanidhya.iiith@gmail.com>
	<1401863911-5947-2-git-send-email-sanidhya.iiith@gmail.com>
	<8761kht2cp.fsf@troll.troll>
	<CAAUTuqCfQdTm5SUm6+P9NOoL7_o1=oZ1ys-ciuf29HG4_3jmXw@mail.gmail.com>
Date: Wed, 04 Jun 2014 13:29:00 +0200
Message-ID: <87oay8sykj.fsf@troll.troll>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v2 1/8] enable sharing of the function
	between migration and bitmap dump
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sanidhya Kashyap <sanidhya.iiith@gmail.com>
Cc: qemu list <qemu-devel@nongnu.org>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Sanidhya Kashyap <sanidhya.iiith@gmail.com> wrote:
>>
>> Exporting a function without a prefix could be dangerous.
>>
>> Later, Juan.
>
> Any particular solution, as the function is being used at two places.


bitmap_* prefix is taken for generic bitmap operations.

qemu_bitmap_range_sync()

migration_bitmap_range_sync()

Use a prefix that is known to be used only on qemu.

I can undrestand why you don't want migration, so qemu_ prefix should do
the trick?


Later, Juan.