From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc Date: Tue, 20 May 2014 15:52:07 +0930 Message-ID: <87oaythsvk.fsf@rustcorp.com.au> References: <1399541296-18810-1-git-send-email-maddy@linux.vnet.ibm.com> <537479E7.90806@linux.vnet.ibm.com> <87wqdik4n5.fsf@rustcorp.com.au> <53797511.1050409@linux.vnet.ibm.com> <20140519164301.eafd3dd288ccb88361ddcfc7@linux-foundation.org> <20140520004429.E660AE009B@blue.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20140520004429.E660AE009B@blue.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Morton Cc: Hugh Dickins , Madhavan Srinivasan , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, benh@kernel.crashing.org, paulus@samba.org, riel@redhat.com, mgorman@suse.de, ak@linux.intel.com, peterz@infradead.org, mingo@kernel.org, dave.hansen@intel.com List-Id: linux-arch.vger.kernel.org "Kirill A. Shutemov" writes: > Andrew Morton wrote: >> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins wrote: >> >> > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be >> > the order of the fault-around size in bytes, and fault_around_pages() >> > use 1UL << (fault_around_order - PAGE_SHIFT) >> >> Yes. And shame on me for missing it (this time!) at review. >> >> There's still time to fix this. Patches, please. > > Here it is. Made at 3.30 AM, build tested only. Prefer on top of Maddy's patch which makes it always a variable, rather than CONFIG_DEBUG_FS. It's got enough hair as it is. Cheers, Rusty. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org ([103.22.144.67]:42378 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969AbaETHRJ (ORCPT ); Tue, 20 May 2014 03:17:09 -0400 From: Rusty Russell Subject: Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc In-Reply-To: <20140520004429.E660AE009B@blue.fi.intel.com> References: <1399541296-18810-1-git-send-email-maddy@linux.vnet.ibm.com> <537479E7.90806@linux.vnet.ibm.com> <87wqdik4n5.fsf@rustcorp.com.au> <53797511.1050409@linux.vnet.ibm.com> <20140519164301.eafd3dd288ccb88361ddcfc7@linux-foundation.org> <20140520004429.E660AE009B@blue.fi.intel.com> Date: Tue, 20 May 2014 15:52:07 +0930 Message-ID: <87oaythsvk.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-arch-owner@vger.kernel.org List-ID: To: "Kirill A. Shutemov" , Andrew Morton Cc: Hugh Dickins , Madhavan Srinivasan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, benh@kernel.crashing.org, paulus@samba.org, riel@redhat.com, mgorman@suse.de, ak@linux.intel.com, peterz@infradead.org, mingo@kernel.org, dave.hansen@intel.com Message-ID: <20140520062207.LHP3agVeEtnBlt0CDfHO1RxC7ZdCXbs3RiiJWGyrYr0@z> "Kirill A. Shutemov" writes: > Andrew Morton wrote: >> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins wrote: >> >> > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be >> > the order of the fault-around size in bytes, and fault_around_pages() >> > use 1UL << (fault_around_order - PAGE_SHIFT) >> >> Yes. And shame on me for missing it (this time!) at review. >> >> There's still time to fix this. Patches, please. > > Here it is. Made at 3.30 AM, build tested only. Prefer on top of Maddy's patch which makes it always a variable, rather than CONFIG_DEBUG_FS. It's got enough hair as it is. Cheers, Rusty. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 9D0A51A084C for ; Tue, 20 May 2014 17:17:07 +1000 (EST) From: Rusty Russell To: "Kirill A. Shutemov" , Andrew Morton Subject: Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc In-Reply-To: <20140520004429.E660AE009B@blue.fi.intel.com> References: <1399541296-18810-1-git-send-email-maddy@linux.vnet.ibm.com> <537479E7.90806@linux.vnet.ibm.com> <87wqdik4n5.fsf@rustcorp.com.au> <53797511.1050409@linux.vnet.ibm.com> <20140519164301.eafd3dd288ccb88361ddcfc7@linux-foundation.org> <20140520004429.E660AE009B@blue.fi.intel.com> Date: Tue, 20 May 2014 15:52:07 +0930 Message-ID: <87oaythsvk.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Cc: linux-arch@vger.kernel.org, riel@redhat.com, Madhavan Srinivasan , dave.hansen@intel.com, peterz@infradead.org, x86@kernel.org, Hugh Dickins , linux-kernel@vger.kernel.org, linux-mm@kvack.org, ak@linux.intel.com, paulus@samba.org, mgorman@suse.de, linuxppc-dev@lists.ozlabs.org, mingo@kernel.org, "Kirill A. Shutemov" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , "Kirill A. Shutemov" writes: > Andrew Morton wrote: >> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins wrote: >> >> > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be >> > the order of the fault-around size in bytes, and fault_around_pages() >> > use 1UL << (fault_around_order - PAGE_SHIFT) >> >> Yes. And shame on me for missing it (this time!) at review. >> >> There's still time to fix this. Patches, please. > > Here it is. Made at 3.30 AM, build tested only. Prefer on top of Maddy's patch which makes it always a variable, rather than CONFIG_DEBUG_FS. It's got enough hair as it is. Cheers, Rusty. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by kanga.kvack.org (Postfix) with ESMTP id E1BF96B0036 for ; Tue, 20 May 2014 03:17:10 -0400 (EDT) Received: by mail-pa0-f46.google.com with SMTP id kq14so55377pab.33 for ; Tue, 20 May 2014 00:17:10 -0700 (PDT) Received: from ozlabs.org (ozlabs.org. [2401:3900:2:1::2]) by mx.google.com with ESMTPS id kv4si9762027pab.78.2014.05.20.00.17.09 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 May 2014 00:17:09 -0700 (PDT) From: Rusty Russell Subject: Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc In-Reply-To: <20140520004429.E660AE009B@blue.fi.intel.com> References: <1399541296-18810-1-git-send-email-maddy@linux.vnet.ibm.com> <537479E7.90806@linux.vnet.ibm.com> <87wqdik4n5.fsf@rustcorp.com.au> <53797511.1050409@linux.vnet.ibm.com> <20140519164301.eafd3dd288ccb88361ddcfc7@linux-foundation.org> <20140520004429.E660AE009B@blue.fi.intel.com> Date: Tue, 20 May 2014 15:52:07 +0930 Message-ID: <87oaythsvk.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" , Andrew Morton Cc: Hugh Dickins , Madhavan Srinivasan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, benh@kernel.crashing.org, paulus@samba.org, riel@redhat.com, mgorman@suse.de, ak@linux.intel.com, peterz@infradead.org, mingo@kernel.org, dave.hansen@intel.com "Kirill A. Shutemov" writes: > Andrew Morton wrote: >> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins wrote: >> >> > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be >> > the order of the fault-around size in bytes, and fault_around_pages() >> > use 1UL << (fault_around_order - PAGE_SHIFT) >> >> Yes. And shame on me for missing it (this time!) at review. >> >> There's still time to fix this. Patches, please. > > Here it is. Made at 3.30 AM, build tested only. Prefer on top of Maddy's patch which makes it always a variable, rather than CONFIG_DEBUG_FS. It's got enough hair as it is. Cheers, Rusty. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751917AbaETHRL (ORCPT ); Tue, 20 May 2014 03:17:11 -0400 Received: from ozlabs.org ([103.22.144.67]:42378 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969AbaETHRJ (ORCPT ); Tue, 20 May 2014 03:17:09 -0400 From: Rusty Russell To: "Kirill A. Shutemov" , Andrew Morton Cc: Hugh Dickins , Madhavan Srinivasan , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, benh@kernel.crashing.org, paulus@samba.org, riel@redhat.com, mgorman@suse.de, ak@linux.intel.com, peterz@infradead.org, mingo@kernel.org, dave.hansen@intel.com Subject: Re: [PATCH V4 0/2] mm: FAULT_AROUND_ORDER patchset performance data for powerpc In-Reply-To: <20140520004429.E660AE009B@blue.fi.intel.com> References: <1399541296-18810-1-git-send-email-maddy@linux.vnet.ibm.com> <537479E7.90806@linux.vnet.ibm.com> <87wqdik4n5.fsf@rustcorp.com.au> <53797511.1050409@linux.vnet.ibm.com> <20140519164301.eafd3dd288ccb88361ddcfc7@linux-foundation.org> <20140520004429.E660AE009B@blue.fi.intel.com> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Tue, 20 May 2014 15:52:07 +0930 Message-ID: <87oaythsvk.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Kirill A. Shutemov" writes: > Andrew Morton wrote: >> On Mon, 19 May 2014 16:23:07 -0700 (PDT) Hugh Dickins wrote: >> >> > Shouldn't FAULT_AROUND_ORDER and fault_around_order be changed to be >> > the order of the fault-around size in bytes, and fault_around_pages() >> > use 1UL << (fault_around_order - PAGE_SHIFT) >> >> Yes. And shame on me for missing it (this time!) at review. >> >> There's still time to fix this. Patches, please. > > Here it is. Made at 3.30 AM, build tested only. Prefer on top of Maddy's patch which makes it always a variable, rather than CONFIG_DEBUG_FS. It's got enough hair as it is. Cheers, Rusty.