From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] kmod: really pass --disable-manpages
Date: Sun, 09 Feb 2014 10:17:05 +0100 [thread overview]
Message-ID: <87ob2g3asu.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <7291a6ec-9696-4801-936d-fdab0d43bcdf@email.android.com> (Thomas De Schampheleire's message of "Sun, 09 Feb 2014 10:11:06 +0100")
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:
Hi,
>> +KMOD_CONF_OPT += --disable-manpages
>> +HOST_KMOD_CONF_OPT = --disable-manpages
>> +
>> ifeq ($(BR2_PACKAGE_ZLIB),y)
>> KMOD_DEPENDENCIES += zlib
>> KMOD_CONF_OPT += --with-zlib
> Aargh, another oops, sorry.
No problem, that's why we have the autobuilders ;)
> Isn't it safer to always use += for this type of variables?
Yes it is, but we typically don't do it for the first(/single)
assignment.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2014-02-09 9:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 8:35 [Buildroot] [git commit] kmod: really pass --disable-manpages Peter Korsgaard
2014-02-09 9:11 ` Thomas De Schampheleire
2014-02-09 9:17 ` Peter Korsgaard [this message]
2014-02-10 17:10 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ob2g3asu.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.