From: Thomas Rast <tr@thomasrast.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Øystein Walle" <oystwa@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v3] stash: handle specifying stashes with spaces
Date: Tue, 07 Jan 2014 23:17:30 +0100 [thread overview]
Message-ID: <87ob3nphc5.fsf@thomasrast.ch> (raw)
In-Reply-To: <xmqq7gabeiqo.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Tue, 07 Jan 2014 10:42:39 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Øystein Walle <oystwa@gmail.com> writes:
>
>> + git stash &&
>> + test_tick &&
>> + echo cow > file &&
>> + git stash &&
>> + git stash apply "stash@{Thu Apr 7 15:17:13 2005 -0700}" &&
>
> This is brittle. If new tests are added before this, the test_tick
> will give you different timestamp and this test will start failing.
>
> Perhaps grab the timestamp out of the stash that was created [...]
Hmm, now that I stare at this, why not simply use something like
git stash apply "stash@{ 0 }"
It seems to refer to the same as stash@{0} as one would expect, while
still triggering the bug with unpatched git-stash.
--
Thomas Rast
tr@thomasrast.ch
next prev parent reply other threads:[~2014-01-07 22:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 8:22 [PATCH v3] stash: handle specifying stashes with spaces Øystein Walle
2014-01-07 18:42 ` Junio C Hamano
2014-01-07 22:17 ` Thomas Rast [this message]
2014-01-07 22:29 ` Junio C Hamano
2014-01-08 0:03 ` Øystein Walle
2014-01-09 18:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ob3nphc5.fsf@thomasrast.ch \
--to=tr@thomasrast.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=oystwa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.