From: "Bjørn Mork" <bjorn@mork.no>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: Yang Yingliang <yangyingliang@huawei.com>,
davem@davemloft.net, netdev@vger.kernel.org,
eric.dumazet@gmail.com, jhs@mojatatu.com,
stephen@networkplumber.org
Subject: Re: [PATCH net-next v2 2/3] net_sched: fix some checkpatch errors
Date: Fri, 08 Nov 2013 12:04:16 +0100 [thread overview]
Message-ID: <87ob5vf93j.fsf@nemi.mork.no> (raw)
In-Reply-To: <527B5160.5070700@redhat.com> (Daniel Borkmann's message of "Thu, 07 Nov 2013 09:37:52 +0100")
Daniel Borkmann <dborkman@redhat.com> writes:
> On 11/07/2013 03:13 AM, Yang Yingliang wrote:
>
>> @@ -263,7 +264,7 @@ void tcf_hash_insert(struct tcf_common *p, struct tcf_hashinfo *hinfo)
>> }
>> EXPORT_SYMBOL(tcf_hash_insert);
>>
>> -static struct tc_action_ops *act_base = NULL;
>> +static struct tc_action_ops *act_base;
>
> From a readability point of view, I think this makes it worse, also the other places
> where you change globals vars like that.
Then you should probably argue for a change to checkpatch. It will make
a lot of noise about such unnecessary initialization.
Bjørn
next prev parent reply other threads:[~2013-11-08 11:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 2:13 [PATCH net-next v2 0/3] net_sched: make tbf support 64bit rates Yang Yingliang
2013-11-07 2:13 ` [PATCH net-next v2 1/3] net_sched: tbf: support of " Yang Yingliang
2013-11-07 14:25 ` Sergei Shtylyov
2013-11-08 1:40 ` Yang Yingliang
2013-11-07 2:13 ` [PATCH net-next v2 2/3] net_sched: fix some checkpatch errors Yang Yingliang
2013-11-07 8:37 ` Daniel Borkmann
2013-11-08 11:04 ` Bjørn Mork [this message]
2013-11-07 14:33 ` Sergei Shtylyov
2013-11-08 1:51 ` Yang Yingliang
2013-11-07 2:13 ` [PATCH net-next v2 3/3] net_sched: Use pr_debug replace printk(KERN_DEBUG ...) Yang Yingliang
2013-11-07 8:30 ` Daniel Borkmann
2013-11-07 8:43 ` Yang Yingliang
2013-11-07 14:43 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ob5vf93j.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.