Re: [PATCH 2/2] qca-swiss-army-knife: add ath10k trace-cmd plugin

[Kalle Valo <kvalo@qca.qualcomm.com>]

Hi Julian,

Julian Calaby <julian.calaby@gmail.com> writes:

> On Thu, Sep 5, 2013 at 2:49 PM, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> "Luis R. Rodriguez" <rodrigue@qca.qualcomm.com> writes:
>>
>>> On Mon, Aug 19, 2013 at 12:11 PM, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>>>> This one's a skeleton as well.
>>>>
>>>> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
>>>
>>> Applied both and pushed, thanks!
>>
>> Thanks.
>>
>>> I just removed 3 trailing spaces on the 2 patches. One had two
>>> trailing spaces, the last patch had one.
>>
>> Oh, sorry about that. Any ideas how I could check for those myself?
>
> If you have coloured diff output enabled in git (color.diff = true)
> then they and other whitespace errors are highlighted in red whenever
> you do diffs.

I don't normally have colors enabled (don't like them), but it seems to
be easy to enable with 'git diff --color'. It's just that it doesn't
seem to work in my terminal, I only see the ANSI codes and no colors.
But this is the best way to do that, just need to fix my terminal.

Thanks!

-- 
Kalle Valo