From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC963-0000tN-8V for qemu-devel@nongnu.org; Wed, 21 Aug 2013 10:09:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VC95x-0007XU-AZ for qemu-devel@nongnu.org; Wed, 21 Aug 2013 10:09:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26457) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VC95x-0007XG-2u for qemu-devel@nongnu.org; Wed, 21 Aug 2013 10:09:09 -0400 From: Markus Armbruster References: <1377090999-18217-1-git-send-email-stefanha@redhat.com> Date: Wed, 21 Aug 2013 16:09:05 +0200 In-Reply-To: <1377090999-18217-1-git-send-email-stefanha@redhat.com> (Stefan Hajnoczi's message of "Wed, 21 Aug 2013 15:16:37 +0200") Message-ID: <87ob8rxhj2.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 0/2] osdep: warn if opening a file O_DIRECT on tmpfs fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Deepak C Shetty , qemu-devel@nongnu.org Stefan Hajnoczi writes: > v2: > * Link in util/qemu-error.o instead of stubbing error_report() [Markus] > > Deepak C Shetty tried to open an image file > O_DIRECT on tmpfs and received EINVAL. This error is too generic, making it > hard to figure out that the problem is -drive ...,cache=none on tmpfs. > > Add a warning when opening a file O_DIRECT on tmpfs fails. Reviewed-by: Markus Armbruster