From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48213)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1UrS0d-0000zw-1s
	for qemu-devel@nongnu.org; Tue, 25 Jun 2013 08:06:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1UrS0Y-0003RE-9y
	for qemu-devel@nongnu.org; Tue, 25 Jun 2013 08:06:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29342)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1UrS0Y-0003R4-0j
	for qemu-devel@nongnu.org; Tue, 25 Jun 2013 08:06:02 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1372125485-11795-12-git-send-email-mrhines@linux.vnet.ibm.com>
	(mrhines@linux.vnet.ibm.com's message of "Mon, 24 Jun 2013 21:58:01
	-0400")
References: <1372125485-11795-1-git-send-email-mrhines@linux.vnet.ibm.com>
	<1372125485-11795-12-git-send-email-mrhines@linux.vnet.ibm.com>
Date: Tue, 25 Jun 2013 14:05:53 +0200
Message-ID: <87obauz97i.fsf@elfo.elfo>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v11 11/15] rdma: core logic
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: mrhines@linux.vnet.ibm.com
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com, chegu_vinod@hp.com, knoel@redhat.com

mrhines@linux.vnet.ibm.com wrote:
> From: "Michael R. Hines" <mrhines@us.ibm.com>
>
> Code that does need to be visible is kept
> well contained inside this file and this is the only
> new additional file to the entire patch.
>
> This file includes the entire protocol and interfaces
> required to perform RDMA migration.
>
> Also, the configure and Makefile modifications to link
> this file are included.
>
> Full documentation is in docs/rdma.txt
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Chegu Vinod <chegu_vinod@hp.com>
> Tested-by: Chegu Vinod <chegu_vinod@hp.com>
> Tested-by: Michael R. Hines <mrhines@us.ibm.com>
> Signed-off-by: Michael R. Hines <mrhines@us.ibm.com>

Reviewed-by: Juan Quintela <quintela@redhat.com> 

The review part is for the everything except migration-rdma.c.  I am
starting looking at that bits,  but they are really complex and my
knowledge of RDMA is nil (notice that there can be relation between the
two concepts).