From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH 1/2] drm/i915: factor out GMCH panel fitting
	code and use for eDP v2
Date: Thu, 25 Apr 2013 17:38:37 +0300
Message-ID: <87obd265g2.fsf@gaia.fi.intel.com>
References: <1366326349-14374-1-git-send-email-jbarnes@virtuousgeek.org>
	<87zjwo55pp.fsf@gaia.fi.intel.com>
	<20130424082921.343fbbab@jbarnes-desktop>
	<20130424165632.GX6169@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [143.182.124.21])
	by gabe.freedesktop.org (Postfix) with ESMTP id 8FB1DE634A
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 25 Apr 2013 07:39:08 -0700 (PDT)
In-Reply-To: <20130424165632.GX6169@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>, Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Daniel Vetter <daniel@ffwll.ch> writes:

> On Wed, Apr 24, 2013 at 08:29:21AM -0700, Jesse Barnes wrote:
>> On Wed, 24 Apr 2013 18:05:54 +0300
>> Mika Kuoppala <mika.kuoppala@linux.intel.com> wrote:
>> 
>> > This is different than it was in lvds_compute_config. If we get called
>> > with DRM_MODE_SCALE_NONE we go to fullscreen instead.
>> > Is this intentional?
>> 
>> Yeah, figured I'd make it identical to the eDP case.  But we could
>> change that one instead if you have a preference.
>
> SCALE_NONE is rejected in both lvds and edp output's set_property. So not
> relevant. Maybe we should smash a WARN into the default case instead?

I missed the SCALE_NONE. drm seems to do checking that no values
outside the enum set gets through but warn wouldn't hurt.
with or without warning added:

Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>

> -Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch