From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPY8C-0006V0-91 for qemu-devel@nongnu.org; Tue, 09 Apr 2013 08:58:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPY8B-0006n7-8R for qemu-devel@nongnu.org; Tue, 09 Apr 2013 08:58:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPY8B-0006n0-0w for qemu-devel@nongnu.org; Tue, 09 Apr 2013 08:58:35 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r39CwYfi028556 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 9 Apr 2013 08:58:34 -0400 From: Juan Quintela In-Reply-To: <1365420597-5506-1-git-send-email-pbonzini@redhat.com> (Paolo Bonzini's message of "Mon, 8 Apr 2013 13:29:53 +0200") References: <1365420597-5506-1-git-send-email-pbonzini@redhat.com> Date: Tue, 09 Apr 2013 14:58:40 +0200 Message-ID: <87obdndfnj.fsf@elfo.elfo> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 0/4] QEMUFile improvements and simplifications Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, owasserm@redhat.com, qemu-devel@nongnu.org Paolo Bonzini wrote: > This fixes Kevin's reported regression with savevm, and simplifies the > QEMUFile code further. > > Patch 2 could be made a bit smaller at the expense of fixing the > regression in the last patch only. I prefer to fix the bug earlier. > > Tested with Autotest. Reviewed-by: Juan Quintela There are code duplicated now, but it was already there, and the patches simplify the rest of the code.