From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55565)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1TvFRj-00037X-2o
	for qemu-devel@nongnu.org; Tue, 15 Jan 2013 17:57:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1TvFRi-0001V1-4O
	for qemu-devel@nongnu.org; Tue, 15 Jan 2013 17:57:31 -0500
Received: from e8.ny.us.ibm.com ([32.97.182.138]:45547)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1TvFRi-0001UW-0S
	for qemu-devel@nongnu.org; Tue, 15 Jan 2013 17:57:30 -0500
Received: from /spool/local
	by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aliguori@us.ibm.com>;
	Tue, 15 Jan 2013 17:57:25 -0500
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by d01dlp03.pok.ibm.com (Postfix) with ESMTP id DA3E1C9003C
	for <qemu-devel@nongnu.org>; Tue, 15 Jan 2013 17:57:21 -0500 (EST)
Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r0FMvLFp350640
	for <qemu-devel@nongnu.org>; Tue, 15 Jan 2013 17:57:21 -0500
Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1])
	by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id r0FMvK2D004244
	for <qemu-devel@nongnu.org>; Tue, 15 Jan 2013 15:57:20 -0700
From: Anthony Liguori <aliguori@us.ibm.com>
In-Reply-To: <1358270033-18064-4-git-send-email-stefanha@redhat.com>
References: <1358270033-18064-1-git-send-email-stefanha@redhat.com>
	<1358270033-18064-4-git-send-email-stefanha@redhat.com>
Date: Tue, 15 Jan 2013 16:57:18 -0600
Message-ID: <87obgqnjg1.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 3/3] configure: try pkg-config for curses
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Vadim Evard <v.e.evard@gmail.com>

Stefan Hajnoczi <stefanha@redhat.com> writes:

> From: Vadim Evard <v.e.evard@gmail.com>
>
> Static linkikng against ncurses may require explicit -ltinfo.
> In case -lcurses and -lncurses both didn't work give pkg-config a
> chance.
>
> Fixes #1094786 for me.
>
> Signed-off-by: Vadim Evard <v.e.evard@gmail.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  configure | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index c908f66..40473a9 100755
> --- a/configure
> +++ b/configure
> @@ -2039,7 +2039,7 @@ fi
>  if test "$mingw32" = "yes" ; then
>      curses_list="-lpdcurses"
>  else
> -    curses_list="-lncurses -lcurses"
> +    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"

Please fix this as a follow up but this is sloppy.

pkg-config spews stuff to stderr when a package isn't found so this ends
up outputting junk in the configure if ncurses isn't found.

Regards,

Anthony Liguori

>  fi
>  
>  if test "$curses" != "no" ; then
> @@ -2052,13 +2052,16 @@ int main(void) {
>    return s != 0;
>  }
>  EOF
> +  IFS=:
>    for curses_lib in $curses_list; do
> +    unset IFS
>      if compile_prog "" "$curses_lib" ; then
>        curses_found=yes
>        libs_softmmu="$curses_lib $libs_softmmu"
>        break
>      fi
>    done
> +  unset IFS
>    if test "$curses_found" = "yes" ; then
>      curses=yes
>    else
> -- 
> 1.8.0.2