From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) Subject: [PATCH review] f2fs: Don't assign e_id in f2fs_acl_from_disk Date: Tue, 25 Dec 2012 16:41:16 -0800 Message-ID: <87obhh63wz.fsf@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Linux Containers Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jaegeuk Kim , Amit Sahrawat , Namjae Jeon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: containers.vger.kernel.org CldpdGggdXNlciBuYW1lc3BhY2VzIGVuYWJsZWQgYnVpbGRpbmcgZjJmcyBmYWlscyB3aXRoOgoK IENDICAgICAgZnMvZjJmcy9hY2wubwpmcy9mMmZzL2FjbC5jOiBJbiBmdW5jdGlvbiDigJhmMmZz X2FjbF9mcm9tX2Rpc2vigJk6CmZzL2YyZnMvYWNsLmM6ODU6MjE6IGVycm9yOiDigJhzdHJ1Y3Qg cG9zaXhfYWNsX2VudHJ54oCZIGhhcyBubyBtZW1iZXIgbmFtZWQg4oCYZV9pZOKAmQptYWtlWzJd OiAqKiogW2ZzL2YyZnMvYWNsLm9dIEVycm9yIDEKbWFrZVsyXTogVGFyZ2V0IGBfX2J1aWxkJyBu b3QgcmVtYWRlIGJlY2F1c2Ugb2YgZXJyb3JzLgoKZV9pZCBpcyBhIGJhY2t3YXJkcyBjb21wYXRp YmlsaXR5IGZpZWxkIG9ubHkgdXNlZCBmb3IgZmlsZSBzeXN0ZW1zCnRoYXQgaGF2ZW4ndCBiZWVu IGNvbnZlcnRlZCB0byB1c2Uga3VpZHMgYW5kIGtnaWRzLiAgV2hlbiB0aGUgcG9zaXgKYWNsIHRh ZyBmaWVsZCBpcyBuZWl0aGVyIEFDTF9VU0VSIG5vciBBQ0xfR1JPVVAgYXNzaWduaW5nIGVfaWQg aXMKdW5uZWNlc3NhcnkuICBSZW1vdmUgdGhlIGFzc2lnbm1lbnQgc28gZjJmcyB3aWxsIGJ1aWxk IHdpdGggdXNlcgpuYW1lc3BhY2VzIGVuYWJsZWQuCgpDYzogSmFlZ2V1ayBLaW0gPGphZWdldWsu a2ltQHNhbXN1bmcuY29tPgpDYzogTmFtamFlIEplb24gPG5hbWphZS5qZW9uQHNhbXN1bmcuY29t PgpDYzogQW1pdCBTYWhyYXdhdCA8YS5zYWhyYXdhdEBzYW1zdW5nLmNvbT4KU2lnbmVkLW9mZi1i eTogIkVyaWMgVy4gQmllZGVybWFuIiA8ZWJpZWRlcm1AeG1pc3Npb24uY29tPgotLS0KCkJhcnJp bmcgb3RoZXIgZmVlZGJhY2sgSSB3aWxsIHB1c2ggdGhpcyBjaGFuZ2UgdG8gTGludXMgd2l0aCBt eSBvdGhlcgpuYW1lc3BhY2UgYnVnIGZpeGVzIGluIHRoZSBuZXh0IGRheSBvciB0d28uCgogZnMv ZjJmcy9hY2wuYyB8ICAgIDEgLQogMSBmaWxlcyBjaGFuZ2VkLCAwIGluc2VydGlvbnMoKyksIDEg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZnMvZjJmcy9hY2wuYyBiL2ZzL2YyZnMvYWNsLmMK aW5kZXggZmVkNzRkMS4uZTk1Yjk0OSAxMDA2NDQKLS0tIGEvZnMvZjJmcy9hY2wuYworKysgYi9m cy9mMmZzL2FjbC5jCkBAIC04Miw3ICs4Miw2IEBAIHN0YXRpYyBzdHJ1Y3QgcG9zaXhfYWNsICpm MmZzX2FjbF9mcm9tX2Rpc2soY29uc3QgY2hhciAqdmFsdWUsIHNpemVfdCBzaXplKQogCQljYXNl IEFDTF9HUk9VUF9PQko6CiAJCWNhc2UgQUNMX01BU0s6CiAJCWNhc2UgQUNMX09USEVSOgotCQkJ YWNsLT5hX2VudHJpZXNbaV0uZV9pZCA9IEFDTF9VTkRFRklORURfSUQ7CiAJCQllbnRyeSA9IChz dHJ1Y3QgZjJmc19hY2xfZW50cnkgKikoKGNoYXIgKillbnRyeSArCiAJCQkJCXNpemVvZihzdHJ1 Y3QgZjJmc19hY2xfZW50cnlfc2hvcnQpKTsKIAkJCWJyZWFrOwotLSAKMS43LjUuNAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQ29udGFpbmVycyBtYWls aW5nIGxpc3QKQ29udGFpbmVyc0BsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xp c3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby9jb250YWluZXJz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752803Ab2LZAl1 (ORCPT ); Tue, 25 Dec 2012 19:41:27 -0500 Received: from out03.mta.xmission.com ([166.70.13.233]:42918 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752665Ab2LZAlZ convert rfc822-to-8bit (ORCPT ); Tue, 25 Dec 2012 19:41:25 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Linux Containers Cc: , , Jaegeuk Kim , Namjae Jeon , Amit Sahrawat Date: Tue, 25 Dec 2012 16:41:16 -0800 Message-ID: <87obhh63wz.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-XM-AID: U2FsdGVkX19CF47bfl3AdTn/7AzjZYHf0RAodQSKpEw= X-SA-Exim-Connect-IP: 98.207.153.68 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.5 XMGappySubj_01 Very gappy subject * 0.1 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -3.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Linux Containers X-Spam-Relay-Country: Subject: [PATCH review] f2fs: Don't assign e_id in f2fs_acl_from_disk X-SA-Exim-Version: 4.2.1 (built Sun, 08 Jan 2012 03:05:19 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With user namespaces enabled building f2fs fails with: CC fs/f2fs/acl.o fs/f2fs/acl.c: In function ‘f2fs_acl_from_disk’: fs/f2fs/acl.c:85:21: error: ‘struct posix_acl_entry’ has no member named ‘e_id’ make[2]: *** [fs/f2fs/acl.o] Error 1 make[2]: Target `__build' not remade because of errors. e_id is a backwards compatibility field only used for file systems that haven't been converted to use kuids and kgids. When the posix acl tag field is neither ACL_USER nor ACL_GROUP assigning e_id is unnecessary. Remove the assignment so f2fs will build with user namespaces enabled. Cc: Jaegeuk Kim Cc: Namjae Jeon Cc: Amit Sahrawat Signed-off-by: "Eric W. Biederman" --- Barring other feedback I will push this change to Linus with my other namespace bug fixes in the next day or two. fs/f2fs/acl.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c index fed74d1..e95b949 100644 --- a/fs/f2fs/acl.c +++ b/fs/f2fs/acl.c @@ -82,7 +82,6 @@ static struct posix_acl *f2fs_acl_from_disk(const char *value, size_t size) case ACL_GROUP_OBJ: case ACL_MASK: case ACL_OTHER: - acl->a_entries[i].e_id = ACL_UNDEFINED_ID; entry = (struct f2fs_acl_entry *)((char *)entry + sizeof(struct f2fs_acl_entry_short)); break; -- 1.7.5.4