From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgUbQ-0007mN-Tg for qemu-devel@nongnu.org; Thu, 06 Dec 2012 01:06:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TgUbL-0003gs-6c for qemu-devel@nongnu.org; Thu, 06 Dec 2012 01:06:32 -0500 Received: from ozlabs.org ([203.10.76.45]:43636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgUbK-0003gg-Ro for qemu-devel@nongnu.org; Thu, 06 Dec 2012 01:06:27 -0500 From: Rusty Russell In-Reply-To: <20121205110807.GA10045@redhat.com> References: <87624iikcw.fsf@rustcorp.com.au> <87zk1uca8z.fsf@elfo.mitica> <87r4n5h0fx.fsf@rustcorp.com.au> <20121205110807.GA10045@redhat.com> Date: Thu, 06 Dec 2012 16:33:06 +1030 Message-ID: <87obi7g1k5.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] virtio: verify that all outstanding buffers are flushed (was Re: vmstate conversion for virtio?) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: QEMU-devel , quintela@redhat.com "Michael S. Tsirkin" writes: > Add sanity check to address the following concern: > > On Wed, Dec 05, 2012 at 09:47:22AM +1030, Rusty Russell wrote: >> All we need is the index of the request; the rest can be re-read from >> the ring. The terminology I used here was loose, indeed. We need the head of the chained descriptor, which we already read from the ring when we gathered the request. Currently we dump a massive structure; it's inelegant at the very least. Cheers, Rusty.