From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Dave Chinner <david@fromorbit.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] mm: trace filemap add and del
Date: Wed, 21 Nov 2012 11:38:00 +0100 [thread overview]
Message-ID: <87obir5jhz.fsf@free.fr> (raw)
In-Reply-To: <20121121035924.GO2591@dastard> (Dave Chinner's message of "Wed, 21 Nov 2012 14:59:24 +1100")
Dave Chinner <david@fromorbit.com> writes:
> We actually have an informal convention for formating filesystem
> trace events, and that is to use the device number....
>
>>
>> > + ),
>> > +
>> > + TP_printk("page=%p pfn=%lu blk=%d:%d inode+ofs=%lu+%lu",
>
> ... and to prefix messages like:
>
> TP_printk("dev %d:%d ino 0x%llx ....
> MAJOR(__entry->dev), MINOR(__entry->dev),
Right, it's sensible. I'll include that for patch V2.
> XFS, ext3/4, jbd/jdb2 and gfs2 follow this convention, so we should
> keep propagating that pattern in the name of consistency, rather
> than having different trace formats for different parts of the
> VFS/FS layers...
Very true.
Cheers.
--
Robert
next prev parent reply other threads:[~2012-11-21 10:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 19:54 [RFC PATCH] mm: trace filemap add and del Robert Jarzmik
2012-11-20 23:57 ` Andrew Morton
2012-11-21 3:59 ` Dave Chinner
2012-11-21 10:38 ` Robert Jarzmik [this message]
2012-11-22 11:51 ` Robert Jarzmik
2012-11-23 0:15 ` Dave Chinner
2012-11-21 10:36 ` Robert Jarzmik
2012-11-21 5:07 ` Hugh Dickins
2012-11-21 10:41 ` Robert Jarzmik
2012-11-23 14:10 ` [PATCH v2] " Robert Jarzmik
2012-11-23 14:10 ` Robert Jarzmik
2012-11-23 23:34 ` [PATCH v3] " Robert Jarzmik
2012-11-23 23:34 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obir5jhz.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.