From: Kevin Hilman <khilman@deeprootsystems.com>
To: Felipe Balbi <balbi@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>
Subject: Re: serial-omap regression?
Date: Thu, 20 Sep 2012 16:03:50 -0700 [thread overview]
Message-ID: <87obl0fga1.fsf@deeprootsystems.com> (raw)
In-Reply-To: <87wqzofgms.fsf@deeprootsystems.com> (Kevin Hilman's message of "Thu, 20 Sep 2012 15:56:11 -0700")
Kevin Hilman <khilman@deeprootsystems.com> writes:
> Hi Felipe,
>
> I just noticed today that one of my boards (3530/Overo) was not making
> it to the console when using an Debian rootfs (nfsroot) but works fine
> with my basic busybox initramfs. Basically, it hangs somewhere between
> finishing the userspace init and launching the login shell.
>
> git bisect ended up pointing the finger at a patch in the OMAP serial
> series[1]. I didn't debug this any further. Any ideas?
>
I forgot to add, this was first noticed when testing with
arm-soc/for-next which has the serial-omap changes pulled in as a
dependency.
Kevin
>
>
> 72256cbd13904d4b4dbb16f5ec83a3293bb292c5 is the first bad commit
> commit 72256cbd13904d4b4dbb16f5ec83a3293bb292c5
> Author: Felipe Balbi <balbi@ti.com>
> Date: Thu Sep 6 15:45:24 2012 +0300
>
> serial: omap: refactor receive_chars() into rdi/rlsi handlers
>
> receive_chars() was getting too big and too difficult
> to follow. By splitting it into separate RDI and RSLI
> handlers, we have smaller functions which are easy
> to understand and only touch the pieces which they need
> to touch.
>
> Tested-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> :040000 040000 69585356cd524953305cfba7d219cd65430a4067 ffdc0c05004afe8b73c1f2c0ba41e412c1faf5f4 M drivers
next prev parent reply other threads:[~2012-09-20 23:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 22:56 serial-omap regression? Kevin Hilman
2012-09-20 23:03 ` Kevin Hilman [this message]
2012-09-21 9:28 ` Felipe Balbi
2012-09-21 9:40 ` Shubhrajyoti
2012-09-21 21:49 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obl0fga1.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.