From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Subject: Re: [Squashfs-devel] [squashfs] Who is responsible for code review? Date: Sat, 23 Jun 2012 14:24:27 +0200 Message-ID: <87oboacj2c.fsf@macbook.be.48ers.dk> References: <1340349302.1986.11.camel@slavad-ubuntu-11> <1340362434.1986.21.camel@slavad-ubuntu-11> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Vyacheslav Dubeyko , richard -rw- weinberger , linux-fsdevel@vger.kernel.org, Vyacheslav.Dubeyko@huawei.com, squashfs-devel@lists.sourceforge.net To: Phillip Lougher Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:64691 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808Ab2FWMYc (ORCPT ); Sat, 23 Jun 2012 08:24:32 -0400 Received: by eaak11 with SMTP id k11so818580eaa.19 for ; Sat, 23 Jun 2012 05:24:31 -0700 (PDT) In-Reply-To: (Phillip Lougher's message of "Sat, 23 Jun 2012 03:01:27 +0100") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: >>>>> "Phillip" == Phillip Lougher writes: Hi, Phillip> The patches in question are adding a new feature to Squashfs. Phillip> New features are always nice to have, but always carry the Phillip> risk of introducing bugs, performance regressions, and Phillip> generally making the code harder to maintain if (as is the Phillip> case with these patches) they have been implemented in a way Phillip> not to my liking. Phillip> I reviewed these patches when they arrived, and I got a poor Phillip> opinion of them. However, I decided to give the patches a Phillip> chance, and wait and see what feedback/code-review they got. Phillip> So far they have received nothing. I would also prefer to see direct mtd support instead of through mtdblock if anything rather than this direct memory access. -- Bye, Peter Korsgaard