From: Chris Ball <cjb@laptop.org>
To: Venkatraman S <svenkatr@ti.com>
Cc: linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org,
Viswanath Puttagunta <vishp@ti.com>
Subject: Re: [PATCH 2/3] mmc: omap_hsmmc: Add fclk frequency to debufs
Date: Wed, 18 Apr 2012 20:04:54 -0400 [thread overview]
Message-ID: <87obqolh7d.fsf@laptop.org> (raw)
In-Reply-To: <1334742553-11060-2-git-send-email-svenkatr@ti.com> (Venkatraman S.'s message of "Wed, 18 Apr 2012 15:19:12 +0530")
Hi,
On Wed, Apr 18 2012, Venkatraman S wrote:
> From: Viswanath Puttagunta <vishp@ti.com>
>
> Add mmc functional clock frequency to list of
> internal state variables to display for debug.
>
> Signed-off-by: Viswanath Puttagunta <vishp@ti.com>
> Signed-off-by: Venkatraman S <svenkatr@ti.com>
> ---
> drivers/mmc/host/omap_hsmmc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index d15b149..d046ba2 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -1683,8 +1683,9 @@ static int omap_hsmmc_regs_show(struct seq_file *s, void *data)
> if (host->pdata->get_context_loss_count)
> context_loss = host->pdata->get_context_loss_count(host->dev);
>
> - seq_printf(s, "mmc%d:\n ctx_loss:\t%d:%d\n\nregs:\n",
> - mmc->index, host->context_loss, context_loss);
> + seq_printf(s, "mmc%d:\n ctx_loss:\t%d:%d\n fclk:\t\t%lu Hz\n\nregs:\n",
> + mmc->index, host->context_loss, context_loss,
Minor nit, but it looks like this line breaks indentation.
> + clk_get_rate(host->fclk));
>
> if (host->suspended) {
> seq_printf(s, "host suspended, can't read registers\n");
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-04-19 0:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 9:49 [PATCH 1/3] mmc: omap_hsmmc: release correct resource Venkatraman S
2012-04-18 9:49 ` [PATCH 2/3] mmc: omap_hsmmc: Add fclk frequency to debufs Venkatraman S
2012-04-19 0:04 ` Chris Ball [this message]
2012-04-19 4:25 ` S, Venkatraman
2012-04-19 4:36 ` Chris Ball
2012-04-19 4:53 ` [PATCH 1/2] " Venkatraman S
2012-04-18 9:49 ` [PATCH 3/3] mmc: omap_hsmmc: If probe fails, give out error messages Venkatraman S
2012-04-18 9:58 ` [PATCH 1/3] mmc: omap_hsmmc: release correct resource Russell King - ARM Linux
2012-04-18 10:26 ` S, Venkatraman
2012-04-18 10:27 ` [PATCH] " Venkatraman S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obqolh7d.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=svenkatr@ti.com \
--cc=vishp@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.