From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH 0/2] virtio: console: control queue race fixes Date: Mon, 09 Jan 2012 13:01:15 +1030 Message-ID: <87obuda9os.fsf@rustcorp.com.au> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org Cc: Amit Shah , Virtualization List , miche@google.com, "Michael S. Tsirkin" List-Id: virtualization@lists.linuxfoundation.org On Fri, 6 Jan 2012 16:19:06 +0530, Amit Shah wrote: > Hello, > > The first patch here fixes the race seen by Miche. He hasn't yet > reported back if this fixes the races he saw, but Joy Pu from Red Hat > tested this patch with hot-plugging/unplugging ports in a loop. > Before this patch, he saw some freezes as well as sysfs warnings. > After applying the patch, all was well. So, the first one should be cc: stable? > The second patch can be folded into the series fixing S4 for > virtio-console. It ensures all callbacks are disabled in the freeze > function. This patch has a dependency on the 1st one in the sense the > double disabling of vq won't make sense w/o patch 1. > > Please review and apply. Done, thanks. Cheers, Rusty.