From: Kevin Hilman <khilman@ti.com>
To: Felipe Balbi <balbi@ti.com>
Cc: linux-omap@vger.kernel.org, p-basak2@ti.com
Subject: Re: [PATCH/RFC] ARM: OMAP: MUSB: disable omap_device auto-suspend
Date: Tue, 29 Nov 2011 16:39:26 -0800 [thread overview]
Message-ID: <87obvuzbnl.fsf@ti.com> (raw)
In-Reply-To: <1322528190-9274-1-git-send-email-khilman@ti.com> (Kevin Hilman's message of "Mon, 28 Nov 2011 16:56:30 -0800")
Kevin Hilman <khilman@ti.com> writes:
> The MUSB driver does not currently implment suspend/resume callbacks,
> seemingly because it does not support cutting power when devices are
> connected in host mode.
>
> Without a proper suspend/resume implementation, the OMAP PM domain
> layer which automatically gates non runtime-suspended devices will
> cause problems in suspend by the drivers ->runtime_suspend() callback
> which will try to cut power.
>
> Fix this by disabling PM domain auto suspending for MUSB until the
> driver can be fixed to properly implement suspend/resume.
>
> Signed-off-by: Kevin Hilman <khilman@ti.com>
I guess it's obvious, but should be stated (I'll update the changelog):
Also note that this prevents the CORE powerdomain from hitting retention
(or off), and thus prevents full-chip retention/off whenever USB devices
are attatched, so this should not be considered as a real fix, but a
workaround that at least prevents driver failure.
Kevin
next prev parent reply other threads:[~2011-11-30 0:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 0:56 [PATCH/RFC] ARM: OMAP: MUSB: disable omap_device auto-suspend Kevin Hilman
2011-11-30 0:39 ` Kevin Hilman [this message]
2011-12-07 6:49 ` Felipe Balbi
2011-12-07 19:37 ` Kevin Hilman
2012-01-29 22:57 ` Grazvydas Ignotas
2012-01-30 22:37 ` NeilBrown
2012-01-31 1:04 ` Grazvydas Ignotas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obvuzbnl.fsf@ti.com \
--to=khilman@ti.com \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=p-basak2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.